core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp - Issue 1194933003: Make CPDF_Object::GetString() a virtual method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

index efe085c2eecd37e3cbb789bc5e468858ca89b4ce..3962ee74c4748b5c370333cb3b8ea089ab7b025c 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

@@ -143,7 +143,7 @@ CFX_DataFilter* _FPDF_CreateFilterFromDict(CPDF_Dictionary* pDict)

pParams = NULL;

}

for (FX_DWORD i = 0; i < ((CPDF_Array*)pDecoder)->GetCount(); i ++) {

- CFX_ByteString name = ((CPDF_Array*)pDecoder)->GetString(i);

+ CFX_ByteString name = ((CPDF_Array*)pDecoder)->GetStringAt(i);

CPDF_Dictionary* pParam = NULL;

if (pParams) {

pParam = ((CPDF_Array*)pParams)->GetDict(i);