core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1194933003: Make CPDF_Object::GetString() a virtual method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index ff1f6c4aa09889389580e6c70295475220ea7324..7046251d9821f9d3c8bebbe492d1a50f6b0f8a72 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -320,7 +320,7 @@ CPDF_Stream* CPDF_StreamParser::ReadInlineStream(CPDF_Document* pDoc, CPDF_Dicti

CPDF_Object* pFilter = pDict->GetElementValue(FX_BSTRC("Filter"));

if (pFilter == NULL) {

} else if (pFilter->GetType() == PDFOBJ_ARRAY) {

- Decoder = ((CPDF_Array*)pFilter)->GetString(0);

+ Decoder = ((CPDF_Array*)pFilter)->GetStringAt(0);

CPDF_Array* pParams = pDict->GetArray(FX_BSTRC("DecodeParms"));

if (pParams) {

pParam = pParams->GetDict(0);