core/src/fpdfapi/fpdf_page/fpdf_page.cpp - Issue 1194933003: Make CPDF_Object::GetString() a virtual method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

index db3966ec175ad912bfefefee28c368dfab0a9a91..57af3a5db97dd3521c3b251e26da96566ae00c23 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

@@ -831,7 +831,7 @@ void CPDF_PageObjects::LoadTransInfo()

if (pGroup == NULL) {

return;

}

- if (pGroup->GetString(FX_BSTRC("S")) != FX_BSTRC("Transparency")) {

+ if (pGroup->GetStringAt("S") != "Transparency") {

return;

}

m_Transparency |= PDFTRANS_GROUP;