core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1194933003: Make CPDF_Object::GetString() a virtual method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 2db8d6095f9399ca838091cd4e1e20a4cea5746e..baa38fd4bcc2093d849a7e399b55e776449e6d46 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -1060,7 +1060,7 @@ static int InsertDeletePDFPage(CPDF_Document* pDoc, CPDF_Dictionary* pPages,

int nKids = pKidList->GetCount();

for (int i = 0; i < nKids; i ++) {

CPDF_Dictionary* pKid = pKidList->GetDict(i);

- if (pKid->GetString("Type") == FX_BSTRC("Page")) {

+ if (pKid->GetStringAt("Type") == "Page") {

if (nPagesToGo == 0) {

if (bInsert) {

pKidList->InsertAt(i, CPDF_Reference::Create(pDoc, pPage->GetObjNum()));