Make CPDF_Object::GetString() a virtual method.

fpdfsdk/src/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../third_party/base/nonstd_unique_ptr.h"
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fsdk_baseannot.h"
@@ skipping 578 matching lines @@
         }
         if (pControl->HasMKEntry("IX"))
         {
                 pDownIcon = pControl->GetDownIcon();
         }
 
         if (pNormalIcon)
         {
                 if (CPDF_Dictionary* pImageDict = pNormalIcon->GetDict())
                 {
-                        if (pImageDict->GetString("Name").IsEmpty())
+                        if (pImageDict->GetStringAt("Name").IsEmpty())
                                 pImageDict->SetAtString("Name", "ImgA");
                 }
         }
 
         if (pRolloverIcon)
         {
                 if (CPDF_Dictionary* pImageDict = pRolloverIcon->GetDict())
                 {
-                        if (pImageDict->GetString("Name").IsEmpty())
+                        if (pImageDict->GetStringAt("Name").IsEmpty())
                                 pImageDict->SetAtString("Name", "ImgB");
                 }
         }
 
         if (pDownIcon)
         {
                 if (CPDF_Dictionary* pImageDict = pDownIcon->GetDict())
                 {
-                        if (pImageDict->GetString("Name").IsEmpty())
+                        if (pImageDict->GetStringAt("Name").IsEmpty())
                                 pImageDict->SetAtString("Name", "ImgC");
                 }
         }
 
         CPDF_IconFit iconFit = pControl->GetIconFit();
 
         CPDFSDK_Document* pDoc = m_pInterForm->GetDocument();
         ASSERT(pDoc != NULL);
         CPDFDoc_Environment* pEnv = pDoc->GetEnv();
 
@@ skipping 892 matching lines @@
         CPDF_Stream* pStream = pAPDict->GetStream(sAPType);
         ASSERT(pStream != NULL);
 
         CPDF_Dictionary* pStreamDict = pStream->GetDict();
         ASSERT(pStreamDict != NULL);
 
         CFX_ByteString sImageAlias = "IMG";
 
         if (CPDF_Dictionary* pImageDict = pImage->GetDict())
         {
-                sImageAlias = pImageDict->GetString("Name");
+                sImageAlias = pImageDict->GetStringAt("Name");
                 if (sImageAlias.IsEmpty())
                         sImageAlias = "IMG";
         }
 
         CPDF_Dictionary* pStreamResList = pStreamDict->GetDict("Resources");
         if (!pStreamResList)
         {
                 pStreamResList = new CPDF_Dictionary();
                 pStreamDict->SetAt("Resources", pStreamResList);
         }
@@ skipping 737 matching lines @@
 
                 CFX_ByteTextBuf fdfEncodedData;
 
                 for (FX_DWORD i = 0; i < pFields->GetCount(); i ++)
                 {
                         CPDF_Dictionary* pField = pFields->GetDict(i);
                         if (pField == NULL) continue;
                         CFX_WideString name;
                         name = pField->GetUnicodeText("T");
                         CFX_ByteString name_b = CFX_ByteString::FromUnicode(name);
-                        CFX_ByteString csBValue = pField->GetString("V");
+                        CFX_ByteString csBValue = pField->GetStringAt("V");
                         CFX_WideString csWValue = PDF_DecodeText(csBValue);
                         CFX_ByteString csValue_b = CFX_ByteString::FromUnicode(csWValue);
 
                         fdfEncodedData = fdfEncodedData<<name_b.GetBuffer(name_b.GetLength());
                         name_b.ReleaseBuffer();
                         fdfEncodedData = fdfEncodedData<<"=";
                         fdfEncodedData = fdfEncodedData<<csValue_b.GetBuffer(csValue_b.GetLength());
                         csValue_b.ReleaseBuffer();
                         if(i != pFields->GetCount()-1)
                                 fdfEncodedData = fdfEncodedData<<"&";
@@ skipping 313 matching lines @@
         m_sType(sType),
         m_sSubType(sSubType),
         m_nTabs(BAI_STRUCTURE)
 {
         ASSERT(m_pPageView != NULL);
 
         CPDF_Page* pPDFPage = m_pPageView->GetPDFPage();
         ASSERT(pPDFPage != NULL);
         ASSERT(pPDFPage->m_pFormDict != NULL);
 
-        CFX_ByteString sTabs = pPDFPage->m_pFormDict->GetString("Tabs");
+        CFX_ByteString sTabs = pPDFPage->m_pFormDict->GetStringAt("Tabs");
 
         if (sTabs == "R")
         {
                 m_nTabs = BAI_ROW;
         }
         else if (sTabs == "C")
         {
                 m_nTabs = BAI_COLUMN;
         }
         else
@@ skipping 302 matching lines @@
 
         CPDF_Annot* pPDFAnnot = pAnnot->GetPDFAnnot();
         ASSERT(pPDFAnnot != NULL);
 
         CPDF_Rect rcAnnot;
         pPDFAnnot->GetRect(rcAnnot);
 
         return rcAnnot;
 }