Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_utils.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "doc_utils.h"
 
 static const int FPDFDOC_UTILS_MAXRECURSION = 32;
@@ skipping 280 matching lines @@
     FX_POSITION pos = pFonts->GetStartPos();
     while (pos) {
         CPDF_Object* pObj = NULL;
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect != NULL && pDirect->GetType() == PDFOBJ_DICTIONARY) {
-            if (((CPDF_Dictionary*)pDirect)->GetString("Type") == "Font") {
+            if (((CPDF_Dictionary*)pDirect)->GetStringAt("Type") == "Font") {
                 dwCount ++;
             }
         }
     }
     return dwCount;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, FX_DWORD index, CFX_ByteString& csNameTag)
 {
     if (pFormDict == NULL) {
         return NULL;
@@ skipping 13 matching lines @@
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
-        if (pElement->GetString("Type") != "Font") {
+        if (pElement->GetStringAt("Type") != "Font") {
             continue;
         }
         if (dwCount == index) {
             csNameTag = csKey;
             return pDocument->LoadFont(pElement);
         }
         dwCount ++;
     }
     return NULL;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, CFX_ByteString csNameTag)
 {
     CFX_ByteString csAlias = PDF_NameDecode(csNameTag);
     if (pFormDict == NULL || csAlias.IsEmpty()) {
         return NULL;
     }
     CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
     if (pDR == NULL) {
         return NULL;
     }
     CPDF_Dictionary* pFonts = pDR->GetDict("Font");
     if (pFonts == NULL) {
         return NULL;
     }
     CPDF_Dictionary* pElement = pFonts->GetDict(csAlias);
     if (pElement == NULL) {
         return NULL;
     }
-    if (pElement->GetString("Type") == "Font") {
+    if (pElement->GetStringAt("Type") == "Font") {
         return pDocument->LoadFont(pElement);
     }
     return NULL;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, CFX_ByteString csFontName, CFX_ByteString& csNameTag)
 {
     if (pFormDict == NULL || csFontName.IsEmpty()) {
         return NULL;
     }
     CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
@@ skipping 10 matching lines @@
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
-        if (pElement->GetString("Type") != "Font") {
+        if (pElement->GetStringAt("Type") != "Font") {
             continue;
         }
         CPDF_Font* pFind = pDocument->LoadFont(pElement);
         if (pFind == NULL) {
             continue;
         }
         CFX_ByteString csBaseFont;
         csBaseFont = pFind->GetBaseFont();
         csBaseFont.Remove(' ');
         if (csBaseFont == csFontName) {
@@ skipping 22 matching lines @@
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
-        if (pElement->GetString("Type") != "Font") {
+        if (pElement->GetStringAt("Type") != "Font") {
             continue;
         }
         CPDF_Font* pFind = pDocument->LoadFont(pElement);
         if (pFind == NULL) {
             continue;
         }
         CFX_SubstFont* pSubst = (CFX_SubstFont*)pFind->GetSubstFont();
         if (pSubst == NULL) {
             continue;
         }
@@ skipping 38 matching lines @@
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
-        if (pElement->GetString("Type") != "Font") {
+        if (pElement->GetStringAt("Type") != "Font") {
             continue;
         }
         if (pFont->GetFontDict() == pElement) {
             csNameTag = csKey;
             return TRUE;
         }
     }
     return FALSE;
 }
 FX_BOOL FindInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, CFX_ByteString csFontName, CPDF_Font*& pFont, CFX_ByteString& csNameTag)
@@ skipping 18 matching lines @@
         CFX_ByteString csKey, csTmp;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
-        if (pElement->GetString("Type") != "Font") {
+        if (pElement->GetStringAt("Type") != "Font") {
             continue;
         }
         pFont = pDocument->LoadFont(pElement);
         if (pFont == NULL) {
             continue;
         }
         CFX_ByteString csBaseFont;
         csBaseFont = pFont->GetBaseFont();
         csBaseFont.Remove(' ');
         if (csBaseFont == csFontName) {
@@ skipping 93 matching lines @@
     if (pFonts == NULL) {
         return;
     }
     pFonts->RemoveAt(csNameTag);
 }
 CPDF_Font* GetDefaultInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument)
 {
     if (pFormDict == NULL) {
         return NULL;
     }
-    CPDF_DefaultAppearance cDA = pFormDict->GetString("DA");
+    CPDF_DefaultAppearance cDA = pFormDict->GetStringAt("DA");
     CFX_ByteString csFontNameTag;
     FX_FLOAT fFontSize;
     cDA.GetFont(csFontNameTag, fFontSize);
     return GetInterFormFont(pFormDict, pDocument, csFontNameTag);
 }
 CPDF_IconFit::ScaleMethod CPDF_IconFit::GetScaleMethod()
 {
     if (m_pDict == NULL) {
         return Always;
     }
-    CFX_ByteString csSW = m_pDict->GetString("SW", "A");
+    CFX_ByteString csSW = m_pDict->GetStringAt("SW", "A");
     if (csSW == "B") {
         return Bigger;
     } else if (csSW == "S") {
         return Smaller;
     } else if (csSW == "N") {
         return Never;
     }
     return Always;
 }
 FX_BOOL CPDF_IconFit::IsProportionalScale()
 {
     if (m_pDict == NULL) {
         return TRUE;
     }
-    return m_pDict->GetString("S", "P") != "A";
+    return m_pDict->GetStringAt("S", "P") != "A";
 }
 void CPDF_IconFit::GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom)
 {
     fLeft = fBottom = 0.5;
     if (m_pDict == NULL) {
         return;
     }
     CPDF_Array* pA = m_pDict->GetArray("A");
     if (pA != NULL) {
         FX_DWORD dwCount = pA->GetCount();
@@ skipping 34 matching lines @@
     CPDF_Object* pAttr = pFieldDict->GetElementValue(name);
     if (pAttr) {
         return pAttr;
     }
     CPDF_Dictionary* pParent = pFieldDict->GetDict("Parent");
     if (pParent == NULL) {
         return NULL;
     }
     return FPDF_GetFieldAttr(pParent, name, nLevel + 1);
 }