Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_ocg.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 static int32_t FPDFDOC_OCG_FindGroup(const CPDF_Object *pObject, const CPDF_Dictionary *pGroupDict)
 {
     if (pObject == NULL || pGroupDict == NULL) {
@@ skipping 18 matching lines @@
 {
     FXSYS_assert(pDict != NULL);
     CPDF_Object *pIntent = pDict->GetElementValue(FX_BSTRC("Intent"));
     if (pIntent == NULL) {
         return csElement == csDef;
     }
     CFX_ByteString bsIntent;
     if (pIntent->GetType() == PDFOBJ_ARRAY) {
         FX_DWORD dwCount = ((CPDF_Array*)pIntent)->GetCount();
         for (FX_DWORD i = 0; i < dwCount; i++) {
-            bsIntent = ((CPDF_Array*)pIntent)->GetString(i);
+            bsIntent = ((CPDF_Array*)pIntent)->GetStringAt(i);
             if (bsIntent == FX_BSTRC("All") || bsIntent == csElement) {
                 return TRUE;
             }
         }
         return FALSE;
     }
     bsIntent = pIntent->GetString();
     return bsIntent == FX_BSTRC("All") || bsIntent == csElement;
 }
 static CPDF_Dictionary* FPDFDOC_OCG_GetConfig(CPDF_Document *pDoc, const CPDF_Dictionary *pOCGDict, const CFX_ByteStringC& bsState)
@@ skipping 51 matching lines @@
 {
     m_OCGStates.clear();
 }
 FX_BOOL CPDF_OCContext::LoadOCGStateFromConfig(const CFX_ByteStringC& csConfig, const CPDF_Dictionary *pOCGDict, FX_BOOL &bValidConfig) const
 {
     CPDF_Dictionary *pConfig = FPDFDOC_OCG_GetConfig(m_pDocument, pOCGDict, csConfig);
     if (!pConfig) {
         return TRUE;
     }
     bValidConfig = TRUE;
-    FX_BOOL bState = pConfig->GetString(FX_BSTRC("BaseState"), FX_BSTRC("ON")) != FX_BSTRC("OFF");
+    FX_BOOL bState = pConfig->GetStringAt("BaseState", "ON") != "OFF";
     CPDF_Array *pArray = pConfig->GetArray(FX_BSTRC("ON"));
     if (pArray) {
         if (FPDFDOC_OCG_FindGroup(pArray, pOCGDict) >= 0) {
             bState = TRUE;
         }
     }
     pArray = pConfig->GetArray(FX_BSTRC("OFF"));
     if (pArray) {
         if (FPDFDOC_OCG_FindGroup(pArray, pOCGDict) >= 0) {
             bState = FALSE;
         }
     }
     pArray = pConfig->GetArray(FX_BSTRC("AS"));
     if (pArray) {
         CFX_ByteString csFind = csConfig + FX_BSTRC("State");
         int32_t iCount = pArray->GetCount();
         for (int32_t i = 0; i < iCount; i ++) {
             CPDF_Dictionary *pUsage = pArray->GetDict(i);
             if (!pUsage) {
                 continue;
             }
-            if (pUsage->GetString(FX_BSTRC("Event"), FX_BSTRC("View")) != csConfig) {
+            if (pUsage->GetStringAt("Event", "View") != csConfig) {
                 continue;
             }
             CPDF_Array *pOCGs = pUsage->GetArray(FX_BSTRC("OCGs"));
             if (!pOCGs) {
                 continue;
             }
             if (FPDFDOC_OCG_FindGroup(pOCGs, pOCGDict) < 0) {
                 continue;
             }
             CPDF_Dictionary *pState = pUsage->GetDict(csConfig);
             if (!pState) {
                 continue;
             }
-            bState = pState->GetString(csFind) != FX_BSTRC("OFF");
+            bState = pState->GetStringAt(csFind) != "OFF";
         }
     }
     return bState;
 }
 FX_BOOL CPDF_OCContext::LoadOCGState(const CPDF_Dictionary *pOCGDict) const
 {
     if (!FPDFDOC_OCG_HasIntent(pOCGDict, FX_BSTRC("View"), FX_BSTRC("View"))) {
         return TRUE;
     }
     CFX_ByteString csState = FPDFDOC_OCG_GetUsageTypeString(m_eUsageType);
     CPDF_Dictionary *pUsage = pOCGDict->GetDict(FX_BSTRC("Usage"));
     if (pUsage) {
         CPDF_Dictionary *pState = pUsage->GetDict(csState);
         if (pState) {
             CFX_ByteString csFind = csState + FX_BSTRC("State");
             if (pState->KeyExist(csFind)) {
-                return pState->GetString(csFind) != FX_BSTRC("OFF");
+                return pState->GetStringAt(csFind) != "OFF";
             }
         }
         if (csState != FX_BSTRC("View")) {
             pState = pUsage->GetDict(FX_BSTRC("View"));
             if (pState && pState->KeyExist(FX_BSTRC("ViewState"))) {
-                return pState->GetString(FX_BSTRC("ViewState")) != FX_BSTRC("OFF");
+                return pState->GetStringAt("ViewState") != "OFF";
             }
         }
     }
     FX_BOOL bDefValid = FALSE;
     return LoadOCGStateFromConfig(csState, pOCGDict, bDefValid);
 }
 
 FX_BOOL CPDF_OCContext::GetOCGVisible(const CPDF_Dictionary* pOCGDict)
 {
     if (!pOCGDict)
@@ skipping 11 matching lines @@
 FX_BOOL CPDF_OCContext::GetOCGVE(CPDF_Array *pExpression, FX_BOOL bFromConfig, int nLevel)
 {
     if (nLevel > 32) {
         return FALSE;
     }
     if (pExpression == NULL) {
         return FALSE;
     }
     int32_t iCount = pExpression->GetCount();
     CPDF_Object *pOCGObj;
-    CFX_ByteString csOperator = pExpression->GetString(0);
+    CFX_ByteString csOperator = pExpression->GetStringAt(0);
     if (csOperator == FX_BSTRC("Not")) {
         pOCGObj = pExpression->GetElementValue(1);
         if (pOCGObj == NULL) {
             return FALSE;
         }
         if (pOCGObj->GetType() == PDFOBJ_DICTIONARY) {
             return !(bFromConfig ? LoadOCGState((CPDF_Dictionary*)pOCGObj) : GetOCGVisible((CPDF_Dictionary*)pOCGObj));
         } else if (pOCGObj->GetType() == PDFOBJ_ARRAY) {
             return !GetOCGVE((CPDF_Array*)pOCGObj, bFromConfig, nLevel + 1);
         } else {
@@ skipping 27 matching lines @@
     }
     return FALSE;
 }
 FX_BOOL CPDF_OCContext::LoadOCMDState(const CPDF_Dictionary *pOCMDDict, FX_BOOL bFromConfig)
 {
     FXSYS_assert(pOCMDDict != NULL);
     CPDF_Array *pVE = pOCMDDict->GetArray(FX_BSTRC("VE"));
     if (pVE != NULL) {
         return GetOCGVE(pVE, bFromConfig);
     }
-    CFX_ByteString csP = pOCMDDict->GetString(FX_BSTRC("P"), FX_BSTRC("AnyOn"));
+    CFX_ByteString csP = pOCMDDict->GetStringAt("P", "AnyOn");
     CPDF_Object *pOCGObj = pOCMDDict->GetElementValue(FX_BSTRC("OCGs"));
     if (pOCGObj == NULL) {
         return TRUE;
     }
     if (pOCGObj->GetType() == PDFOBJ_DICTIONARY) {
         return bFromConfig ? LoadOCGState((CPDF_Dictionary*)pOCGObj) : GetOCGVisible((CPDF_Dictionary*)pOCGObj);
     }
     if (pOCGObj->GetType() != PDFOBJ_ARRAY) {
         return TRUE;
     }
@@ skipping 21 matching lines @@
             return FALSE;
         }
     }
     return bState;
 }
 FX_BOOL CPDF_OCContext::CheckOCGVisible(const CPDF_Dictionary *pOCGDict)
 {
     if (pOCGDict == NULL) {
         return TRUE;
     }
-    CFX_ByteString csType = pOCGDict->GetString(FX_BSTRC("Type"), FX_BSTRC("OCG"));
+    CFX_ByteString csType = pOCGDict->GetStringAt("Type", "OCG");
     if (csType == FX_BSTRC("OCG")) {
         return GetOCGVisible(pOCGDict);
     } else {
         return LoadOCMDState(pOCGDict, FALSE);
     }
 }
 void CPDF_OCContext::ResetOCContext()
 {
     m_OCGStates.clear();
 }