Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_formcontrol.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 CPDF_FormControl::CPDF_FormControl(CPDF_FormField* pField, CPDF_Dictionary* pWidgetDict)
 {
     m_pField = pField;
@@ skipping 28 matching lines @@
 void CPDF_FormControl::SetOnStateName(const CFX_ByteString& csOn)
 {
     ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton);
     CFX_ByteString csValue = csOn;
     if (csValue.IsEmpty()) {
         csValue = "Yes";
     }
     if (csValue == "Off") {
         csValue = "Yes";
     }
-    CFX_ByteString csAS = m_pWidgetDict->GetString("AS", "Off");
+    CFX_ByteString csAS = m_pWidgetDict->GetStringAt("AS", "Off");
     if (csAS != "Off") {
         m_pWidgetDict->SetAtName("AS", csValue);
     }
     CPDF_Dictionary* pAP = m_pWidgetDict->GetDict("AP");
     if (pAP == NULL) {
         return;
     }
     FX_POSITION pos1 = pAP->GetStartPos();
     while (pos1) {
         CFX_ByteString csKey1;
@@ skipping 37 matching lines @@
     return csOn;
 }
 CFX_WideString CPDF_FormControl::GetExportValue()
 {
     ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton);
     CFX_ByteString csOn = GetOnStateName();
     if (GetType() == CPDF_FormField::RadioButton || GetType() == CPDF_FormField::CheckBox) {
         CPDF_Object* pOpt = FPDF_GetFieldAttr(m_pField->m_pDict, "Opt");
         if (pOpt != NULL && pOpt->GetType() == PDFOBJ_ARRAY) {
             int iIndex = m_pField->GetControlIndex(this);
-            csOn = ((CPDF_Array*)pOpt)->GetString(iIndex);
+            csOn = ((CPDF_Array*)pOpt)->GetStringAt(iIndex);
         }
     }
     if (csOn.IsEmpty()) {
         csOn = "Yes";
     }
     CFX_WideString csWOn = PDF_DecodeText(csOn);
     return csWOn;
 }
 FX_BOOL CPDF_FormControl::IsChecked()
 {
     ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton);
     CFX_ByteString csOn = GetOnStateName();
-    CFX_ByteString csAS = m_pWidgetDict->GetString("AS");
+    CFX_ByteString csAS = m_pWidgetDict->GetStringAt("AS");
     return csAS == csOn;
 }
 FX_BOOL CPDF_FormControl::IsDefaultChecked()
 {
     ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton);
     CPDF_Object* pDV = FPDF_GetFieldAttr(m_pField->m_pDict, "DV");
     if (pDV == NULL) {
         return FALSE;
     }
     CFX_ByteString csDV = pDV->GetString();
     CFX_ByteString csOn = GetOnStateName();
     return (csDV == csOn);
 }
 void CPDF_FormControl::CheckControl(FX_BOOL bChecked)
 {
     ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton);
     CFX_ByteString csOn = GetOnStateName();
-    CFX_ByteString csOldAS = m_pWidgetDict->GetString("AS", "Off");
+    CFX_ByteString csOldAS = m_pWidgetDict->GetStringAt("AS", "Off");
     CFX_ByteString csAS = "Off";
     if (bChecked) {
         csAS = csOn;
     }
     if (csOldAS == csAS) {
         return;
     }
     m_pWidgetDict->SetAtName("AS", csAS);
     m_pForm->m_bUpdated = TRUE;
 }
@@ skipping 20 matching lines @@
     CPDF_RenderContext context;
     context.Create(pPage);
     context.DrawObjectList(pDevice, &form, &matrix, pOptions);
 }
 const FX_CHAR* g_sHighlightingMode[] = {"N", "I", "O", "P", "T", ""};
 CPDF_FormControl::HighlightingMode CPDF_FormControl::GetHighlightingMode()
 {
     if (m_pWidgetDict == NULL) {
         return Invert;
     }
-    CFX_ByteString csH = m_pWidgetDict->GetString("H", "I");
+    CFX_ByteString csH = m_pWidgetDict->GetStringAt("H", "I");
     int i = 0;
     while (g_sHighlightingMode[i][0] != '\0') {
         if (csH.Equal(g_sHighlightingMode[i])) {
             return (HighlightingMode)i;
         }
         i ++;
     }
     return Invert;
 }
 CPDF_ApSettings CPDF_FormControl::GetMK(FX_BOOL bCreate)
@@ skipping 80 matching lines @@
     } else {
         return m_pField->GetAdditionalAction();
     }
 }
 CPDF_DefaultAppearance CPDF_FormControl::GetDefaultAppearance()
 {
     if (m_pWidgetDict == NULL) {
         return CFX_ByteString();
     }
     if (m_pWidgetDict->KeyExist("DA")) {
-        return m_pWidgetDict->GetString("DA");
+        return m_pWidgetDict->GetStringAt("DA");
     } else {
         CPDF_Object* pObj = FPDF_GetFieldAttr(m_pField->m_pDict, "DA");
         if (pObj == NULL) {
             return m_pField->m_pForm->GetDefaultAppearance();
         }
         return pObj->GetString();
     }
 }
 
 CPDF_Font* CPDF_FormControl::GetDefaultControlFont()
@@ skipping 167 matching lines @@
     }
     return m_pDict->GetDict(FX_BSTRC("IF"));
 }
 int CPDF_ApSettings::GetTextPosition()
 {
     if (m_pDict == NULL) {
         return TEXTPOS_CAPTION;
     }
     return m_pDict->GetInteger(FX_BSTRC("TP"), TEXTPOS_CAPTION);
 }