Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_form.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "doc_utils.h"
 
 const int nMaxRecursion = 32;
@@ skipping 1113 matching lines @@
 {
     m_bUpdated = TRUE;
     RemoveInterFormFont(m_pFormDict, csNameTag);
 }
 CPDF_DefaultAppearance CPDF_InterForm::GetDefaultAppearance()
 {
     CFX_ByteString csDA;
     if (m_pFormDict == NULL) {
         return csDA;
     }
-    csDA = m_pFormDict->GetString("DA");
+    csDA = m_pFormDict->GetStringAt("DA");
     return csDA;
 }
 CPDF_Font* CPDF_InterForm::GetDefaultFormFont()
 {
     return GetDefaultInterFormFont(m_pFormDict, m_pDocument);
 }
 int CPDF_InterForm::GetFormAlignment()
 {
     if (m_pFormDict == NULL) {
         return 0;
@@ skipping 122 matching lines @@
     if (pPageDict == NULL) {
         return;
     }
     CPDF_Array* pAnnots = pPageDict->GetArray(FX_BSTRC("Annots"));
     if (pAnnots == NULL) {
         return;
     }
     int iAnnotCount = pAnnots->GetCount();
     for (int i = 0; i < iAnnotCount; i++) {
         CPDF_Dictionary* pAnnot = pAnnots->GetDict(i);
-        if (pAnnot != NULL && pAnnot->GetString(FX_BSTRC("Subtype")) == "Widget") {
+        if (pAnnot && pAnnot->GetStringAt("Subtype") == "Widget") {
             LoadField(pAnnot);
         }
     }
 }
 CPDF_FormField* CPDF_InterForm::AddTerminalField(const CPDF_Dictionary* pFieldDict)
 {
     if (!pFieldDict->KeyExist(FX_BSTRC("T"))) {
         return NULL;
     }
     CPDF_Dictionary* pDict = (CPDF_Dictionary*)pFieldDict;
     CFX_WideString csWName = GetFullName(pDict);
     if (csWName.IsEmpty()) {
         return NULL;
     }
     CPDF_FormField* pField = NULL;
     pField = m_pFieldTree->GetField(csWName);
     if (pField == NULL) {
         CPDF_Dictionary *pParent = (CPDF_Dictionary*)pFieldDict;
         if (!pFieldDict->KeyExist(FX_BSTRC("T")) &&
-            pFieldDict->GetString(FX_BSTRC("Subtype")) == FX_BSTRC("Widget")) {
+            pFieldDict->GetStringAt("Subtype") == "Widget") {
             pParent = pFieldDict->GetDict(FX_BSTRC("Parent"));
             if (!pParent) {
                 pParent = (CPDF_Dictionary*)pFieldDict;
             }
         }
         if (pParent && pParent != pFieldDict && !pParent->KeyExist(FX_BSTRC("FT"))) {
             if (pFieldDict->KeyExist(FX_BSTRC("FT"))) {
                 CPDF_Object *pFTValue = pFieldDict->GetElementValue(FX_BSTRC("FT"));
                 if (pFTValue) {
                     pParent->SetAt(FX_BSTRC("FT"), pFTValue->Clone());
@@ skipping 13 matching lines @@
             if (pClone) {
                 pDict->SetAt("T", pClone);
             } else {
                 pDict->SetAtName("T", "");
             }
         }
         m_pFieldTree->SetField(csWName, pField);
     }
     CPDF_Array* pKids = pFieldDict->GetArray("Kids");
     if (pKids == NULL) {
-        if (pFieldDict->GetString("Subtype") == "Widget") {
+        if (pFieldDict->GetStringAt("Subtype") == "Widget") {
             AddControl(pField, pFieldDict);
         }
     } else {
         for (FX_DWORD i = 0; i < pKids->GetCount(); i ++) {
             CPDF_Dictionary* pKid = pKids->GetDict(i);
             if (pKid == NULL) {
                 continue;
             }
-            if (pKid->GetString("Subtype") != "Widget") {
+            if (pKid->GetStringAt("Subtype") != "Widget") {
                 continue;
             }
             AddControl(pField, pKid);
         }
     }
     return pField;
 }
 CPDF_FormControl* CPDF_InterForm::AddControl(const CPDF_FormField* pField, const CPDF_Dictionary* pWidgetDict)
 {
     void *rValue = NULL;
@@ skipping 20 matching lines @@
         FX_DWORD dwFlags = pField->GetFieldFlags();
         if (dwFlags & 0x04) {
             continue;
         }
         FX_BOOL bFind = TRUE;
         if (fields != NULL) {
             bFind = fields->Find(pField, 0) >= 0;
         }
         if ((bIncludeOrExclude && bFind) || (!bIncludeOrExclude && !bFind)) {
             CPDF_Dictionary *pFieldDict = pField->m_pDict;
-            if ((dwFlags & 0x02) != 0 && pFieldDict->GetString("V").IsEmpty()) {
+            if ((dwFlags & 0x02) != 0 &&
+                pFieldDict->GetStringAt("V").IsEmpty()) {
                 return pField;
             }
         }
     }
     return NULL;
 }
 CFDF_Document* CPDF_InterForm::ExportToFDF(const CFX_WideStringC& pdf_path, FX_BOOL bSimpleFileSpec) const
 {
     CFX_PtrArray fields;
     int nCount = m_pFieldTree->m_Root.CountFields();
@@ skipping 32 matching lines @@
         CPDF_FormField* pField = m_pFieldTree->m_Root.GetField(i);
         if (pField == NULL || pField->GetType() == CPDF_FormField::PushButton) {
             continue;
         }
         FX_DWORD dwFlags = pField->GetFieldFlags();
         if (dwFlags & 0x04) {
             continue;
         }
         FX_BOOL bFind = fields.Find(pField, 0) >= 0;
         if ((bIncludeOrExclude && bFind) || (!bIncludeOrExclude && !bFind)) {
-            if ((dwFlags & 0x02) != 0 && pField->m_pDict->GetString("V").IsEmpty()) {
+            if ((dwFlags & 0x02) != 0 &&
+                pField->m_pDict->GetStringAt("V").IsEmpty()) {
                 continue;
             }
             CFX_WideString fullname = GetFullName(pField->GetFieldDict());
             CPDF_Dictionary* pFieldDict = CPDF_Dictionary::Create();
             if (pFieldDict == NULL) {
                 return NULL;
             }
             CPDF_String* pString = CPDF_String::Create(fullname);
             if (pString == NULL) {
                 pFieldDict->Release();
@@ skipping 25 matching lines @@
     int32_t m_codePage;
 } g_fieldEncoding[] = {
     { "BigFive", 950 },
     { "GBK", 936 },
     { "Shift-JIS", 932 },
     { "UHC", 949 },
 };
 static void FPDFDOC_FDF_GetFieldValue(CPDF_Dictionary *pFieldDict, CFX_WideString &csValue, CFX_ByteString &bsEncoding)
 {
     ASSERT(pFieldDict != NULL);
-    CFX_ByteString csBValue = pFieldDict->GetString("V");
+    CFX_ByteString csBValue = pFieldDict->GetStringAt("V");
     int32_t iCount = sizeof(g_fieldEncoding) / sizeof(g_fieldEncoding[0]);
     int32_t i = 0;
     for (; i < iCount; ++i)
         if (bsEncoding == g_fieldEncoding[i].m_name) {
             break;
         }
     if (i < iCount) {
         CFX_CharMap *pCharMap = CFX_CharMap::GetDefaultMapper(g_fieldEncoding[i].m_codePage);
         FXSYS_assert(pCharMap != NULL);
         csValue.ConvertFrom(csBValue, pCharMap);
@@ skipping 75 matching lines @@
         return FALSE;
     }
     CPDF_Dictionary* pMainDict = pFDF->GetRoot()->GetDict("FDF");
     if (pMainDict == NULL) {
         return FALSE;
     }
     CPDF_Array* pFields = pMainDict->GetArray("Fields");
     if (pFields == NULL) {
         return FALSE;
     }
-    m_bsEncoding = pMainDict->GetString(FX_BSTRC("Encoding"));
+    m_bsEncoding = pMainDict->GetStringAt("Encoding");
     if (bNotify && m_pFormNotify != NULL) {
         int iRet = m_pFormNotify->BeforeFormImportData(this);
         if (iRet < 0) {
             return FALSE;
         }
     }
     for (FX_DWORD i = 0; i < pFields->GetCount(); i ++) {
         CPDF_Dictionary* pField = pFields->GetDict(i);
         if (pField == NULL) {
             continue;
@@ skipping 45 matching lines @@
                 continue;
             }
             CPDF_FormControl* pControl = NULL;
             if (m_ControlMap.Lookup(pAnnotDict, (void*&)pControl)) {
                 return iNewPage;
             }
         }
     } while (TRUE);
     return -1;
 }