Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_basic.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 const int nMaxRecursion = 32;
 int CPDF_Dest::GetPageIndex(CPDF_Document* pDoc)
 {
@@ skipping 69 matching lines @@
         m_pRoot = NULL;
 }
 static CPDF_Object* SearchNameNode(CPDF_Dictionary* pNode, const CFX_ByteString& csName,
                                    int& nIndex, CPDF_Array** ppFind, int nLevel = 0)
 {
     if (nLevel > nMaxRecursion) {
         return NULL;
     }
     CPDF_Array* pLimits = pNode->GetArray(FX_BSTRC("Limits"));
     if (pLimits != NULL) {
-        CFX_ByteString csLeft = pLimits->GetString(0);
-        CFX_ByteString csRight = pLimits->GetString(1);
+        CFX_ByteString csLeft = pLimits->GetStringAt(0);
+        CFX_ByteString csRight = pLimits->GetStringAt(1);
         if (csLeft.Compare(csRight) > 0) {
             CFX_ByteString csTmp = csRight;
             csRight = csLeft;
             csLeft = csTmp;
         }
         if (csName.Compare(csLeft) < 0 || csName.Compare(csRight) > 0) {
             return NULL;
         }
     }
     CPDF_Array* pNames = pNode->GetArray(FX_BSTRC("Names"));
     if (pNames) {
         FX_DWORD dwCount = pNames->GetCount() / 2;
         for (FX_DWORD i = 0; i < dwCount; i ++) {
-            CFX_ByteString csValue = pNames->GetString(i * 2);
+            CFX_ByteString csValue = pNames->GetStringAt(i * 2);
             int32_t iCompare = csValue.Compare(csName);
             if (iCompare <= 0) {
                 if (ppFind != NULL) {
                     *ppFind = pNames;
                 }
                 if (iCompare < 0) {
                     continue;
                 }
             } else {
                 break;
@@ skipping 29 matching lines @@
     CPDF_Array* pNames = pNode->GetArray(FX_BSTRC("Names"));
     if (pNames) {
         int nCount = pNames->GetCount() / 2;
         if (nIndex >= nCurIndex + nCount) {
             nCurIndex += nCount;
             return NULL;
         } else {
             if (ppFind != NULL) {
                 *ppFind = pNames;
             }
-            csName = pNames->GetString((nIndex - nCurIndex) * 2);
+            csName = pNames->GetStringAt((nIndex - nCurIndex) * 2);
             return pNames->GetElementValue((nIndex - nCurIndex) * 2 + 1);
         }
     }
     CPDF_Array* pKids = pNode->GetArray(FX_BSTRC("Kids"));
     if (pKids == NULL) {
         return NULL;
     }
     for (FX_DWORD i = 0; i < pKids->GetCount(); i ++) {
         CPDF_Dictionary* pKid = pKids->GetDict(i);
         if (pKid == NULL) {
@@ skipping 150 matching lines @@
 }
 FX_BOOL CPDF_FileSpec::GetFileName(CFX_WideString &csFileName) const
 {
     if (m_pObj == NULL) {
         return FALSE;
     }
     if (m_pObj->GetType() == PDFOBJ_DICTIONARY) {
         CPDF_Dictionary* pDict = (CPDF_Dictionary*)m_pObj;
         csFileName = pDict->GetUnicodeText(FX_BSTRC("UF"));
         if (csFileName.IsEmpty()) {
-            csFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("F")));
+            csFileName = CFX_WideString::FromLocal(pDict->GetStringAt("F"));
         }
-        if (pDict->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL")) {
+        if (pDict->GetStringAt("FS") == "URL") {
             return TRUE;
         }
         if (csFileName.IsEmpty()) {
             if (pDict->KeyExist(FX_BSTRC("DOS"))) {
-                csFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("DOS")));
+                csFileName = CFX_WideString::FromLocal(
+                    pDict->GetStringAt("DOS"));
             } else if (pDict->KeyExist(FX_BSTRC("Mac"))) {
-                csFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("Mac")));
+                csFileName = CFX_WideString::FromLocal(
+                    pDict->GetStringAt("Mac"));
             } else if (pDict->KeyExist(FX_BSTRC("Unix"))) {
-                csFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("Unix")));
+                csFileName = CFX_WideString::FromLocal(
+                    pDict->GetStringAt("Unix"));
             } else {
                 return FALSE;
             }
         }
     } else {
         csFileName = CFX_WideString::FromLocal(m_pObj->GetString());
     }
     csFileName = FILESPEC_DecodeFileName(csFileName);
     return TRUE;
 }
 CPDF_FileSpec::CPDF_FileSpec()
 {
     m_pObj = CPDF_Dictionary::Create();
     if (m_pObj != NULL) {
         ((CPDF_Dictionary*)m_pObj)->SetAtName(FX_BSTRC("Type"), FX_BSTRC("Filespec"));
     }
 }
 FX_BOOL CPDF_FileSpec::IsURL() const
 {
     if (m_pObj == NULL) {
         return FALSE;
     }
     if (m_pObj->GetType() != PDFOBJ_DICTIONARY) {
         return FALSE;
     }
-    return ((CPDF_Dictionary*)m_pObj)->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL");
+    return ((CPDF_Dictionary*)m_pObj)->GetStringAt("FS") == "URL";
 }
 CFX_WideString FILESPEC_EncodeFileName(const CFX_WideStringC& filepath)
 {
     if (filepath.GetLength() <= 1) {
         return CFX_WideString();
     }
 #if _FXM_PLATFORM_  == _FXM_PLATFORM_WINDOWS_
     if (filepath.GetAt(1) == ':') {
         CFX_WideString result;
         result = '/';
@@ skipping 149 matching lines @@
         }
         n--;
     }
     if (pValue != NULL) {
         pValue = pValue->GetDirect();
         if (pValue->GetType() == PDFOBJ_DICTIONARY) {
             CPDF_Dictionary* pLabel = (CPDF_Dictionary*)pValue;
             if (pLabel->KeyExist(FX_BSTRC("P"))) {
                 wsLabel += pLabel->GetUnicodeText(FX_BSTRC("P"));
             }
-            CFX_ByteString bsNumberingStyle = pLabel->GetString(FX_BSTRC("S"), NULL);
+            CFX_ByteString bsNumberingStyle = pLabel->GetStringAt("S", NULL);
             int nLabelNum = nPage - n + pLabel->GetInteger(FX_BSTRC("St"), 1);
             CFX_WideString wsNumPortion = _GetLabelNumPortion(nLabelNum, bsNumberingStyle);
             wsLabel += wsNumPortion;
             return wsLabel;
         }
     }
     wsLabel.Format(L"%d", nPage + 1);
     return wsLabel;
 }
 int32_t CPDF_PageLabel::GetPageByLabel(const CFX_ByteStringC& bsLabel) const
@@ skipping 19 matching lines @@
     if (nPage > 0 && nPage <= nPages) {
         return nPage;
     }
     return -1;
 }
 int32_t CPDF_PageLabel::GetPageByLabel(const CFX_WideStringC& wsLabel) const
 {
     CFX_ByteString bsLabel = PDF_EncodeText(wsLabel.GetPtr());
     return GetPageByLabel(bsLabel);
 }