Make CPDF_Object::GetString() a virtual method.

core/src/fpdfdoc/doc_ap.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fpdfdoc/fpdf_vt.h"
 #include "pdf_vt.h"
 #include "../../include/fpdfdoc/fpdf_ap.h"
@@ skipping 10 matching lines @@
         if (flags & (1 << 17)) {
             return CPVT_GenerateAP::GenerateComboBoxAP(pDoc, pAnnotDict);
         } else {
             return CPVT_GenerateAP::GenerateListBoxAP(pDoc, pAnnotDict);
         }
     } else if (field_type == "Btn") {
         if (!(flags & (1 << 16))) {
             if (!pAnnotDict->KeyExist("AS")) {
                 if (CPDF_Dictionary* pParentDict = pAnnotDict->GetDict("Parent")) {
                     if (pParentDict->KeyExist("AS")) {
-                        pAnnotDict->SetAtString("AS", pParentDict->GetString("AS"));
+                        pAnnotDict->SetAtString(
+                            "AS", pParentDict->GetStringAt("AS"));
                     }
                 }
             }
         }
     }
     return FALSE;
 }
 class CPVT_FontMap : public IPVT_FontMap
 {
 public:
@@ skipping 209 matching lines @@
         pFormDict = pRootDict->GetDict("AcroForm");
     }
     if (!pFormDict) {
         return FALSE;
     }
     CFX_ByteString DA;
     if (CPDF_Object* pDAObj = FPDF_GetFieldAttr(pAnnotDict, "DA")) {
         DA = pDAObj->GetString();
     }
     if (DA.IsEmpty()) {
-        DA = pFormDict->GetString("DA");
+        DA = pFormDict->GetStringAt("DA");
     }
     if (DA.IsEmpty()) {
         return FALSE;
     }
     CPDF_SimpleParser syntax(DA);
     syntax.FindTagParam("Tf", 2);
     CFX_ByteString sFontName = syntax.GetWord();
     sFontName = PDF_NameDecode(sFontName);
     if (sFontName.IsEmpty()) {
         return FALSE;
@@ skipping 65 matching lines @@
     FX_FLOAT fBorderWidth = 1;
     CPVT_Dash dsBorder(3, 0, 0);
     CPVT_Color crLeftTop, crRightBottom;
     if (CPDF_Dictionary * pBSDict = pAnnotDict->GetDict("BS")) {
         if (pBSDict->KeyExist("W")) {
             fBorderWidth = pBSDict->GetNumber("W");
         }
         if (CPDF_Array * pArray = pBSDict->GetArray("D")) {
             dsBorder = CPVT_Dash(pArray->GetInteger(0), pArray->GetInteger(1), pArray->GetInteger(2));
         }
-        switch (pBSDict->GetString("S").GetAt(0)) {
+        switch (pBSDict->GetStringAt("S").GetAt(0)) {
             case 'S':
                 nBorderStyle = PBS_SOLID;
                 break;
             case 'D':
                 nBorderStyle = PBS_DASH;
                 break;
             case 'B':
                 nBorderStyle = PBS_BEVELED;
                 fBorderWidth *= 2;
                 crLeftTop = CPVT_Color(CT_GRAY, 1);
@@ skipping 443 matching lines @@
         case CT_GRAY:
             sColorStream << color.fColor1 << " " << (bFillOrStroke ? "g" : "G") << "\n";
             break;
         case CT_CMYK:
             sColorStream << color.fColor1 << " " << color.fColor2 << " " << color.fColor3 << " " << color.fColor4 << " "
                          << (bFillOrStroke ? "k" : "K") << "\n";
             break;
     }
     return sColorStream.GetByteString();
 }