Make CPDF_Object::GetString() a virtual method.

core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <utility>
 #include <vector>
 
 #include "../../../include/fpdfapi/fpdf_module.h"
@@ skipping 263 matching lines @@
             return err;
         }
         CPDF_CryptoHandler* pCryptoHandler = m_pSecurityHandler->CreateCryptoHandler();
         if (!pCryptoHandler->Init(m_pEncryptDict, m_pSecurityHandler)) {
             delete pCryptoHandler;
             pCryptoHandler = NULL;
             return PDFPARSE_ERROR_HANDLER;
         }
         m_Syntax.SetEncrypt(pCryptoHandler);
     } else if (m_pEncryptDict) {
-        CFX_ByteString filter = m_pEncryptDict->GetString(FX_BSTRC("Filter"));
+        CFX_ByteString filter = m_pEncryptDict->GetStringAt("Filter");
         CPDF_SecurityHandler* pSecurityHandler = NULL;
         FX_DWORD err = PDFPARSE_ERROR_HANDLER;
         if (filter == FX_BSTRC("Standard")) {
             pSecurityHandler = FPDF_CreateStandardSecurityHandler();
             err = PDFPARSE_ERROR_PASSWORD;
         }
         if (pSecurityHandler == NULL) {
             return PDFPARSE_ERROR_HANDLER;
         }
         if (!pSecurityHandler->OnInit(this, m_pEncryptDict)) {
@@ skipping 485 matching lines @@
                                 }
                                 FX_FILESIZE obj_end = 0;
                                 CPDF_Object *pObject = ParseIndirectObjectAtByStrict(m_pDocument, obj_pos, objnum, NULL, &obj_end);
                                 if (pObject) {
                                     int iType = pObject->GetType();
                                     if (iType == PDFOBJ_STREAM) {
                                         CPDF_Stream* pStream = (CPDF_Stream*)pObject;
                                         CPDF_Dictionary* pDict = pStream->GetDict();
                                         if (pDict) {
                                             if (pDict->KeyExist(FX_BSTRC("Type"))) {
-                                                CFX_ByteString bsValue = pDict->GetString(FX_BSTRC("Type"));
+                                                CFX_ByteString bsValue = pDict->GetStringAt("Type");
                                                 if (bsValue == FX_BSTRC("XRef") && pDict->KeyExist(FX_BSTRC("Size"))) {
                                                     CPDF_Object* pRoot = pDict->GetElement(FX_BSTRC("Root"));
                                                     if (pRoot && pRoot->GetDict() && pRoot->GetDict()->GetElement(FX_BSTRC("Pages"))) {
                                                         if (m_pTrailer) {
                                                             m_pTrailer->Release();
                                                         }
                                                         m_pTrailer = (CPDF_Dictionary*)pDict->Clone();
                                                     }
                                                 }
                                             }
@@ skipping 656 matching lines @@
         return NULL;
     }
     return (CPDF_Dictionary*)pObj;
 }
 FX_DWORD CPDF_Parser::GetPermissions(FX_BOOL bCheckRevision)
 {
     if (m_pSecurityHandler == NULL) {
         return (FX_DWORD) - 1;
     }
     FX_DWORD dwPermission = m_pSecurityHandler->GetPermissions();
-    if (m_pEncryptDict && m_pEncryptDict->GetString(FX_BSTRC("Filter")) == FX_BSTRC("Standard")) {
+    if (m_pEncryptDict && m_pEncryptDict->GetStringAt("Filter") == "Standard") {
         dwPermission &= 0xFFFFFFFC;
         dwPermission |= 0xFFFFF0C0;
         if(bCheckRevision && m_pEncryptDict->GetInteger(FX_BSTRC("R")) == 2) {
             dwPermission &= 0xFFFFF0FF;
         }
     }
     return dwPermission;
 }
 FX_BOOL CPDF_Parser::IsOwner()
 {
@@ skipping 1563 matching lines @@
                     CPDF_Array *pArray = pObj->GetArray();
                     for (FX_DWORD k = 0; k < pArray->GetCount(); k++) {
                         new_obj_array.Add(pArray->GetElement(k));
                     }
                 }
                 break;
             case PDFOBJ_STREAM:
                 pObj = pObj->GetDict();
             case PDFOBJ_DICTIONARY: {
                     CPDF_Dictionary *pDict = pObj->GetDict();
-                    if (pDict && pDict->GetString("Type") == "Page" && !bParsePage) {
+                    if (!bParsePage &&
+                        pDict &&
+                        pDict->GetStringAt("Type") == "Page") {
                         continue;
                     }
                     FX_POSITION pos = pDict->GetStartPos();
                     while (pos) {
                         CPDF_Object *value;
                         CFX_ByteString key;
                         value = pDict->GetNextElement(pos, key);
                         if (key != "Parent") {
                             new_obj_array.Add(value);
                         }
@@ skipping 410 matching lines @@
                     if (pItem && pItem->GetType() == PDFOBJ_REFERENCE) {
                         UnavailObjList.Add(((CPDF_Reference *)pItem)->GetRefObjNum());
                     }
                 }
             }
         }
         if (pObj->GetType() != PDFOBJ_DICTIONARY) {
             pObj->Release();
             continue;
         }
-        CFX_ByteString type = pObj->GetDict()->GetString(FX_BSTRC("Type"));
+        CFX_ByteString type = pObj->GetDict()->GetStringAt("Type");
         if (type == FX_BSTRC("Pages")) {
             m_PagesArray.Add(pObj);
             continue;
         }
         pObj->Release();
     }
     m_PageObjList.RemoveAll();
     if (UnavailObjList.GetSize()) {
         m_PageObjList.Append(UnavailObjList);
         return FALSE;
@@ skipping 663 matching lines @@
         pPage->Release();
         return TRUE;
     }
     if (pPage->GetType() != PDFOBJ_DICTIONARY) {
         pPage->Release();
         m_docStatus = PDF_DATAAVAIL_ERROR;
         return FALSE;
     }
     pPageNode->m_dwPageNo = dwPageNo;
     CPDF_Dictionary* pDict = pPage->GetDict();
-    CFX_ByteString type = pDict ? pDict->GetString(FX_BSTRC("Type")) : CFX_ByteString();
+    CFX_ByteString type = pDict ? pDict->GetStringAt("Type") : CFX_ByteString();
     if (type == FX_BSTRC("Pages")) {
         pPageNode->m_type = PDF_PAGENODE_PAGES;
         CPDF_Object *pKids = pDict->GetElement(FX_BSTRC("Kids"));
         if (!pKids) {
             m_docStatus = PDF_DATAAVAIL_PAGE;
             return TRUE;
         }
         switch (pKids->GetType()) {
             case PDFOBJ_REFERENCE: {
                     CPDF_Reference *pKid = (CPDF_Reference *)pKids;
@@ skipping 455 matching lines @@
 }
 CPDF_PageNode::~CPDF_PageNode()
 {
     int32_t iSize = m_childNode.GetSize();
     for (int32_t i = 0; i < iSize; ++i) {
         CPDF_PageNode* pNode = (CPDF_PageNode*)m_childNode[i];
         delete pNode;
     }
     m_childNode.RemoveAll();
 }