Make CPDF_Object::GetString() a virtual method.

core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_parser.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 
 CPDF_Document::CPDF_Document(CPDF_Parser* pParser) : CPDF_IndirectObjects(pParser)
@@ skipping 33 matching lines @@
     m_pRootDict = pRootObj->GetDict();
     if (m_pRootDict == NULL) {
         return;
     }
     CPDF_Object* pInfoObj = GetIndirectObject(m_pParser->GetInfoObjNum());
     if (pInfoObj) {
         m_pInfoDict = pInfoObj->GetDict();
     }
     CPDF_Array* pIDArray = m_pParser->GetIDArray();
     if (pIDArray) {
-        m_ID1 = pIDArray->GetString(0);
-        m_ID2 = pIDArray->GetString(1);
+        m_ID1 = pIDArray->GetStringAt(0);
+        m_ID2 = pIDArray->GetStringAt(1);
     }
     m_PageList.SetSize(_GetPageCount());
 }
 void CPDF_Document::LoadAsynDoc(CPDF_Dictionary *pLinearized)
 {
     m_bLinearized = TRUE;
     m_LastObjNum = m_pParser->GetLastObjNum();
     CPDF_Object* indirectObj = GetIndirectObject(m_pParser->GetRootObjNum());
     m_pRootDict = indirectObj ? indirectObj->GetDict() : NULL;
     if (m_pRootDict == NULL) {
         return;
     }
     indirectObj = GetIndirectObject(m_pParser->GetInfoObjNum());
     m_pInfoDict = indirectObj ? indirectObj->GetDict() : NULL;
     CPDF_Array* pIDArray = m_pParser->GetIDArray();
     if (pIDArray) {
-        m_ID1 = pIDArray->GetString(0);
-        m_ID2 = pIDArray->GetString(1);
+        m_ID1 = pIDArray->GetStringAt(0);
+        m_ID2 = pIDArray->GetStringAt(1);
     }
     FX_DWORD dwPageCount = 0;
     CPDF_Object *pCount = pLinearized->GetElement(FX_BSTRC("N"));
     if (pCount && pCount->GetType() == PDFOBJ_NUMBER) {
         dwPageCount = pCount->GetInteger();
     }
     m_PageList.SetSize(dwPageCount);
     CPDF_Object *pNo = pLinearized->GetElement(FX_BSTRC("P"));
     if (pNo && pNo->GetType() == PDFOBJ_NUMBER) {
         m_dwFirstPageNo = pNo->GetInteger();
@@ skipping 250 matching lines @@
 }
 FX_BOOL CPDF_Document::IsOwner() const
 {
     if (m_pParser == NULL) {
         return TRUE;
     }
     return m_pParser->IsOwner();
 }
 FX_BOOL CPDF_Document::IsFormStream(FX_DWORD objnum, FX_BOOL& bForm) const
 {
-    {
-        CPDF_Object* pObj;
-        if (m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, (void*&)pObj)) {
-            bForm = pObj->GetType() == PDFOBJ_STREAM &&
-                    ((CPDF_Stream*)pObj)->GetDict()->GetString(FX_BSTRC("Subtype")) == FX_BSTRC("Form");
-            return TRUE;
-        }
+    CPDF_Object* pObj;
+    if (m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, (void*&)pObj)) {
+        bForm =
+            (pObj->GetType() == PDFOBJ_STREAM &&
+             ((CPDF_Stream*)pObj)->GetDict()->GetStringAt("Subtype") == "Form");
+        return TRUE;
     }
+
     if (m_pParser == NULL) {
         bForm = FALSE;
         return TRUE;
     }
     return m_pParser->IsFormStream(objnum, bForm);
 }
 void CPDF_Document::ClearPageData()
 {
     if (m_pDocPage) {
         CPDF_ModuleMgr::Get()->GetPageModule()->ClearDoc(this);
     }
 }
 void CPDF_Document::ClearRenderData()
 {
     if (m_pDocRender) {
         CPDF_ModuleMgr::Get()->GetRenderModule()->ClearDocData(m_pDocRender);
     }
 }