Make CPDF_Object::GetString() a virtual method.

core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "font_int.h"
 #include "../fpdf_cmaps/cmap_int.h"
@@ skipping 854 matching lines @@
     int err = FXFT_Select_Charmap(face, encoding);
     if (err) {
         err = FXFT_Select_Charmap(face, FXFT_ENCODING_UNICODE);
     }
     if (err && FXFT_Get_Face_Charmaps(face)) {
         FXFT_Set_Charmap(face, *FXFT_Get_Face_Charmaps(face));
     }
 }
 FX_BOOL CPDF_CIDFont::_Load()
 {
-    if (m_pFontDict->GetString(FX_BSTRC("Subtype")) == FX_BSTRC("TrueType")) {
+    if (m_pFontDict->GetStringAt("Subtype") == "TrueType") {
         return LoadGB2312();
     }
     CPDF_Array* pFonts = m_pFontDict->GetArray(FX_BSTRC("DescendantFonts"));
     if (pFonts == NULL) {
         return FALSE;
     }
     if (pFonts->GetCount() != 1) {
         return FALSE;
     }
     CPDF_Dictionary* pCIDFontDict = pFonts->GetDict(0);
     if (pCIDFontDict == NULL) {
         return FALSE;
     }
-    m_BaseFont = pCIDFontDict->GetString(FX_BSTRC("BaseFont"));
+    m_BaseFont = pCIDFontDict->GetStringAt("BaseFont");
     if ((m_BaseFont.Compare("CourierStd") == 0 || m_BaseFont.Compare("CourierStd-Bold") == 0
             || m_BaseFont.Compare("CourierStd-BoldOblique") == 0 || m_BaseFont.Compare("CourierStd-Oblique") == 0)
             && !IsEmbedded()) {
         m_bAdobeCourierStd = TRUE;
     }
     CPDF_Dictionary* pFontDesc = pCIDFontDict->GetDict(FX_BSTRC("FontDescriptor"));
     if (pFontDesc) {
         LoadFontDescriptor(pFontDesc);
     }
     CPDF_Object* pEncoding = m_pFontDict->GetElementValue(FX_BSTRC("Encoding"));
     if (pEncoding == NULL) {
         return FALSE;
     }
-    CFX_ByteString subtype = pCIDFontDict->GetString(FX_BSTRC("Subtype"));
+    CFX_ByteString subtype = pCIDFontDict->GetStringAt("Subtype");
     m_bType1 = FALSE;
     if (subtype == FX_BSTRC("CIDFontType0")) {
         m_bType1 = TRUE;
     }
     if (pEncoding->GetType() == PDFOBJ_NAME) {
         CFX_ByteString cmap = pEncoding->GetString();
         m_pCMap = CPDF_ModuleMgr::Get()->GetPageModule()->GetFontGlobals()->m_CMapManager.GetPredefinedCMap(cmap,
                   m_pFontFile && m_bType1);
     } else if (pEncoding->GetType() == PDFOBJ_STREAM) {
         m_pAllocatedCMap = m_pCMap = new CPDF_CMap;
         CPDF_Stream* pStream = (CPDF_Stream*)pEncoding;
         CPDF_StreamAcc acc;
         acc.LoadAllData(pStream, FALSE);
         m_pCMap->LoadEmbedded(acc.GetData(), acc.GetSize());
     } else {
         return FALSE;
     }
     if (m_pCMap == NULL) {
         return FALSE;
     }
     m_Charset = m_pCMap->m_Charset;
     if (m_Charset == CIDSET_UNKNOWN) {
         CPDF_Dictionary* pCIDInfo = pCIDFontDict->GetDict(FX_BSTRC("CIDSystemInfo"));
         if (pCIDInfo) {
-            m_Charset = _CharsetFromOrdering(pCIDInfo->GetString(FX_BSTRC("Ordering")));
+            m_Charset = _CharsetFromOrdering(pCIDInfo->GetStringAt("Ordering"));
         }
     }
     if (m_Charset != CIDSET_UNKNOWN)
         m_pCID2UnicodeMap = CPDF_ModuleMgr::Get()->GetPageModule()->GetFontGlobals()->m_CMapManager.GetCID2UnicodeMap(m_Charset,
                             m_pFontFile == NULL && (m_pCMap->m_Coding == CIDCODING_CID || pCIDFontDict->KeyExist(FX_BSTRC("W"))));
     if (m_Font.GetFace()) {
         if (m_bType1) {
             FXFT_Select_Charmap(m_Font.GetFace(), FXFT_ENCODING_UNICODE);
         } else {
             FT_UseCIDCharmap(m_Font.GetFace(), m_pCMap->m_Coding);
@@ skipping 444 matching lines @@
                 iCurElement ++;
                 if (iCurElement == nElements) {
                     width_status = 0;
                 }
             }
         }
     }
 }
 FX_BOOL CPDF_CIDFont::LoadGB2312()
 {
-    m_BaseFont = m_pFontDict->GetString(FX_BSTRC("BaseFont"));
+    m_BaseFont = m_pFontDict->GetStringAt("BaseFont");
     CPDF_Dictionary* pFontDesc = m_pFontDict->GetDict(FX_BSTRC("FontDescriptor"));
     if (pFontDesc) {
         LoadFontDescriptor(pFontDesc);
     }
     m_Charset = CIDSET_GB1;
     m_bType1 = FALSE;
     m_pCMap = CPDF_ModuleMgr::Get()->GetPageModule()->GetFontGlobals()->m_CMapManager.GetPredefinedCMap(
                   FX_BSTRC("GBK-EUC-H"), FALSE);
     m_pCID2UnicodeMap = CPDF_ModuleMgr::Get()->GetPageModule()->GetFontGlobals()->m_CMapManager.GetCID2UnicodeMap(m_Charset, FALSE);
     if (!IsEmbedded()) {
@@ skipping 180 matching lines @@
         if (middlecode > CID) {
             end = middle - 1;
         } else if (middlecode < CID) {
             begin = middle + 1;
         } else {
             return &Japan1_VertCIDs[middle].a;
         }
     }
     return NULL;
 }