Make CPDF_Object::GetString() a virtual method.

core/src/fpdfapi/fpdf_font/fpdf_font.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_pageobj.h"
 #include "font_int.h"
@@ skipping 403 matching lines @@
 }
 const uint8_t ChineseFontNames[][5] = {
     {0xCB, 0xCE, 0xCC, 0xE5, 0x00},
     {0xBF, 0xAC, 0xCC, 0xE5, 0x00},
     {0xBA, 0xDA, 0xCC, 0xE5, 0x00},
     {0xB7, 0xC2, 0xCB, 0xCE, 0x00},
     {0xD0, 0xC2, 0xCB, 0xCE, 0x00}
 };
 CPDF_Font* CPDF_Font::CreateFontF(CPDF_Document* pDoc, CPDF_Dictionary* pFontDict)
 {
-    CFX_ByteString type = pFontDict->GetString(FX_BSTRC("Subtype"));
+    CFX_ByteString type = pFontDict->GetStringAt("Subtype");
     CPDF_Font* pFont;
     if (type == FX_BSTRC("TrueType")) {
         {
 #if _FXM_PLATFORM_  == _FXM_PLATFORM_WINDOWS_ || _FXM_PLATFORM_ == _FXM_PLATFORM_LINUX_ || _FXM_PLATFORM_ == _FXM_PLATFORM_ANDROID_ || _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
-            CFX_ByteString basefont = pFontDict->GetString(FX_BSTRC("BaseFont"));
+            CFX_ByteString basefont = pFontDict->GetStringAt("BaseFont");
             CFX_ByteString tag = basefont.Left(4);
             int i;
             int count = sizeof(ChineseFontNames) / sizeof(ChineseFontNames[0]);
             for (i = 0; i < count; ++i) {
                 if (tag == CFX_ByteString((const FX_CHAR*)ChineseFontNames[i])) {
                     break;
                 }
             }
             if (i < count) {
                 CPDF_Dictionary* pFontDesc = pFontDict->GetDict(FX_BSTRC("FontDescriptor"));
@@ skipping 24 matching lines @@
         delete pFont;
         return NULL;
     }
     return pFont;
 }
 FX_BOOL CPDF_Font::Load()
 {
     if (m_pFontDict == NULL) {
         return FALSE;
     }
-    CFX_ByteString type = m_pFontDict->GetString(FX_BSTRC("Subtype"));
-    m_BaseFont = m_pFontDict->GetString(FX_BSTRC("BaseFont"));
+    CFX_ByteString type = m_pFontDict->GetStringAt("Subtype");
+    m_BaseFont = m_pFontDict->GetStringAt("BaseFont");
     if (type == FX_BSTRC("MMType1")) {
         type = FX_BSTRC("Type1");
     }
     return _Load();
 }
 static CFX_WideString _FontMap_GetWideString(CFX_CharMap* pMap, const CFX_ByteString& bytestr)
 {
     return ((CPDF_FontCharMap*)pMap)->m_pFont->DecodeString(bytestr);
 }
 static CFX_ByteString _FontMap_GetByteString(CFX_CharMap* pMap, const CFX_WideString& widestr)
@@ skipping 280 matching lines @@
             bsEncoding = FX_BSTRC("WinAnsiEncoding");
         }
         GetPredefinedEncoding(iBaseEncoding, bsEncoding);
         return;
     }
     if (pEncoding->GetType() != PDFOBJ_DICTIONARY) {
         return;
     }
     CPDF_Dictionary* pDict = (CPDF_Dictionary*)pEncoding;
     if (iBaseEncoding != PDFFONT_ENCODING_ADOBE_SYMBOL && iBaseEncoding != PDFFONT_ENCODING_ZAPFDINGBATS) {
-        CFX_ByteString bsEncoding = pDict->GetString(FX_BSTRC("BaseEncoding"));
+        CFX_ByteString bsEncoding = pDict->GetStringAt("BaseEncoding");
         if (bsEncoding.Compare(FX_BSTRC("MacExpertEncoding")) == 0 && bTrueType) {
             bsEncoding = FX_BSTRC("WinAnsiEncoding");
         }
         GetPredefinedEncoding(iBaseEncoding, bsEncoding);
     }
     if ((!bEmbedded || bTrueType) && iBaseEncoding == PDFFONT_ENCODING_BUILTIN) {
         iBaseEncoding = PDFFONT_ENCODING_STANDARD;
     }
     CPDF_Array* pDiffs = pDict->GetArray(FX_BSTRC("Differences"));
     if (pDiffs == NULL) {
@@ skipping 953 matching lines @@
     m_pForm = NULL;
     m_pBitmap = NULL;
     m_bPageRequired = FALSE;
     m_bColored = FALSE;
 }
 CPDF_Type3Char::~CPDF_Type3Char()
 {
     delete m_pForm;
     delete m_pBitmap;
 }