Make CPDF_Object::GetString() a virtual method.

core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxcrt/fx_ext.h"
 #include "../../../include/fpdfapi/fpdf_serial.h"
 #include "editint.h"
 
@@ skipping 911 matching lines @@
     }
     FX_DWORD objnum = pObj->GetObjNum();
     if (m_pParser && m_pParser->m_ObjVersion.GetSize() > (int32_t)objnum && m_pParser->m_ObjVersion[objnum] > 0) {
         return 1;
     }
     if (pObj->GetType() == PDFOBJ_NUMBER) {
         return 1;
     }
     CPDF_Dictionary *pDict = pObj->GetDict();
     if (pObj->GetType() == PDFOBJ_STREAM) {
-        if (pDict && pDict->GetString(FX_BSTRC("Type")) == FX_BSTRC("XRef")) {
+        if (pDict && pDict->GetStringAt("Type") == "XRef") {
             return 0;
         }
         return 1;
     }
     if (pDict) {
         if (pDict == m_pDocument->m_pRootDict || pDict == m_pEncryptDict) {
             return 1;
         }
         if (IsSignatureDict(pDict)) {
             return 1;
         }
-        if (pDict->GetString(FX_BSTRC("Type")) == FX_BSTRC("Page")) {
+        if (pDict->GetStringAt("Type") == "Page") {
             return 1;
         }
     }
     m_pXRefStream->AddObjectNumberToIndexArray(objnum);
     if (m_pXRefStream->CompressIndirectObject(objnum, pObj, this) < 0) {
         return -1;
     }
     if (!_IsXRefNeedEnd(m_pXRefStream, m_dwFlags)) {
         return 0;
     }
@@ skipping 1099 matching lines @@
         }
         FX_DWORD* pBuffer = FX_Alloc(FX_DWORD, 4);
         PDF_GenerateFileID((FX_DWORD)(uintptr_t)this, m_dwLastObjNum, pBuffer);
         CFX_ByteStringC bsBuffer((const uint8_t*)pBuffer, 4 * sizeof(FX_DWORD));
         m_pIDArray->Add(CPDF_String::Create(bsBuffer, TRUE), m_pDocument);
         FX_Free(pBuffer);
         return;
     }
     m_pIDArray->Add(m_pIDArray->GetElement(0)->Clone());
     if (m_pEncryptDict && !pOldIDArray && m_pParser && bNewId) {
-        if (m_pEncryptDict->GetString(FX_BSTRC("Filter")) == FX_BSTRC("Standard")) {
+        if (m_pEncryptDict->GetStringAt("Filter") == "Standard") {
             CPDF_StandardSecurityHandler handler;
             CFX_ByteString user_pass = m_pParser->GetPassword();
             FX_DWORD flag = PDF_ENCRYPT_CONTENT;
             handler.OnCreate(m_pEncryptDict, m_pIDArray, (const uint8_t*)user_pass, user_pass.GetLength(), flag);
             if (m_bNewCrypto) {
                 delete m_pCryptoHandler;
             }
             m_pCryptoHandler = new CPDF_StandardCryptoHandler;
             m_pCryptoHandler->Init(m_pEncryptDict, &handler);
             m_bNewCrypto = TRUE;
@@ skipping 52 matching lines @@
     m_bNewCrypto = FALSE;
     if (!m_bStandardSecurity) {
         return;
     }
     if (m_pEncryptDict) {
         m_pEncryptDict->Release();
         m_pEncryptDict = NULL;
     }
     m_bStandardSecurity = FALSE;
 }