Expose a low-end device mode override flags for non-android OSs as well

base/sys_utils.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef BASE_ANDROID_SYS_UTILS_H_
-#define BASE_ANDROID_SYS_UTILS_H_
+#ifndef BASE_SYS_UTILS_H_
+#define BASE_SYS_UTILS_H_
 
-#include "base/android/jni_android.h"
+#include <stddef.h>
+#include "base/base_export.h"
 
 namespace base {
-namespace android {
 
 class BASE_EXPORT SysUtils {
  public:
-  static bool Register(JNIEnv* env);
-
   // Returns true iff this is a low-end device.

[willchan no longer on Chromium, 2013/12/26 19:02:39]

This is too vague. It was kinda-OK when it was just Android, but for other
platforms? What does "low-end" mean?

[lgombos, 2013/12/27 05:31:44]

I have to agree that it is vague, but fwiw I think making it available to other
OSes does not make it more vague. I expect that the flag could be used the exact
same way as it is on Android for platforms where 'embedded==1'. 

I personally do not feel strongly about "auto-detecting" if chromium runs on
"low-end". Just allowing the command line option to initialize this bit is very
valuable by itself, without the additional runtime detection.

   static bool IsLowEndDevice();
 
   // Return the device's RAM size in kilo-bytes. Used for testing.
   static size_t AmountOfPhysicalMemoryKB();

[willchan no longer on Chromium, 2013/12/26 19:02:39]

Why does this even exist? Why aren't we using SysInfo? How is SysUtils supposed
to be different from SysInfo?

 
  private:
   SysUtils();
-
-  static bool IsLowEndDeviceFromJni();
-  static size_t AmountOfPhysicalMemoryKBFromJni();
 };
 
-}  // namespace android
 }  // namespace base
 
-#endif  // BASE_ANDROID_SYS_UTILS_H_
+#endif  // BASE_SYS_UTILS_H_