Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: runtime/bin/utils_macos.cc

Issue 1194883002: Improve the encoding/decoding to/from system encoding on Windows (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Addressed review comments from lrn@ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/utils_linux.cc ('k') | runtime/bin/utils_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/utils_macos.cc
diff --git a/runtime/bin/utils_macos.cc b/runtime/bin/utils_macos.cc
index 460da354a688527ddc11f39dbd9600744694ee82..4004f38af197fdef1f9ddaa410b9f0bc785265d9 100644
--- a/runtime/bin/utils_macos.cc
+++ b/runtime/bin/utils_macos.cc
@@ -42,47 +42,32 @@ void OSError::SetCodeAndMessage(SubSystem sub_system, int code) {
}
}
-const char* StringUtils::ConsoleStringToUtf8(const char* str) {
- return str;
-}
-
-const char* StringUtils::Utf8ToConsoleString(const char* utf8) {
- return utf8;
-}
-
-char* StringUtils::ConsoleStringToUtf8(char* str) {
- return str;
-}
-
-char* StringUtils::Utf8ToConsoleString(char* utf8) {
- return utf8;
-}
-
-wchar_t* StringUtils::Utf8ToWide(char* utf8) {
+const char* StringUtils::ConsoleStringToUtf8(
+ const char* str, intptr_t len, intptr_t* result_len) {
UNIMPLEMENTED();
return NULL;
}
-const wchar_t* StringUtils::Utf8ToWide(const char* utf8) {
+const char* StringUtils::Utf8ToConsoleString(
+ const char* utf8, intptr_t len, intptr_t* result_len) {
UNIMPLEMENTED();
return NULL;
}
-char* StringUtils::WideToUtf8(wchar_t* str) {
+char* StringUtils::ConsoleStringToUtf8(
+ char* str, intptr_t len, intptr_t* result_len) {
UNIMPLEMENTED();
return NULL;
}
-const char* StringUtils::WideToUtf8(const wchar_t* str) {
+char* StringUtils::Utf8ToConsoleString(
+ char* utf8, intptr_t len, intptr_t* result_len) {
UNIMPLEMENTED();
return NULL;
}
-wchar_t** ShellUtils::GetUnicodeArgv(int* argc) {
- return NULL;
-}
-
-void ShellUtils::FreeUnicodeArgv(wchar_t** argv) {
+bool ShellUtils::GetUtf8Argv(int argc, char** argv) {
+ return false;
}
int64_t TimerUtils::GetCurrentTimeMilliseconds() {
« no previous file with comments | « runtime/bin/utils_linux.cc ('k') | runtime/bin/utils_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698