runtime/bin/file_system_watcher_win.cc - Issue 1194883002: Improve the encoding/decoding to/from system encoding on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_system_watcher_win.cc

Issue 1194883002: Improve the encoding/decoding to/from system encoding on Windows (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Addressed review comments from lrn@ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_system_watcher_win.cc

diff --git a/runtime/bin/file_system_watcher_win.cc b/runtime/bin/file_system_watcher_win.cc

index f0b71f1c3225fea4a94c716eb116884cd46ff477..98642ab46a6585923c714ff4e442499feb17865e 100644

--- a/runtime/bin/file_system_watcher_win.cc

+++ b/runtime/bin/file_system_watcher_win.cc

@@ -13,6 +13,7 @@

#include "bin/builtin.h"

#include "bin/log.h"

#include "bin/utils.h"

+#include "bin/utils_win.h"

namespace dart {

@@ -38,7 +39,7 @@ intptr_t FileSystemWatcher::WatchPath(intptr_t id,

int events,

bool recursive) {

USE(id);

- const wchar_t* name = StringUtils::Utf8ToWide(path);

+ const wchar_t* name = StringUtilsWin::Utf8ToWide(path);

HANDLE dir = CreateFileW(name,

FILE_LIST_DIRECTORY,

FILE_SHARE_READ |

« no previous file with comments | « runtime/bin/extensions_win.cc ('k') | runtime/bin/file_win.cc » ('j') | no next file with comments »