sdk/lib/io/string_transformer.dart - Issue 1194883002: Improve the encoding/decoding to/from system encoding on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/string_transformer.dart

Issue 1194883002: Improve the encoding/decoding to/from system encoding on Windows (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Addressed review comments from kustermann@ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/string_transformer.dart

diff --git a/sdk/lib/io/string_transformer.dart b/sdk/lib/io/string_transformer.dart

index 423a61c39d9da07d26e909d3989d570cfcfed1d3..02df9395764b17369ac16ccbd1325d613164cf18 100644

--- a/sdk/lib/io/string_transformer.dart

+++ b/sdk/lib/io/string_transformer.dart

@@ -5,6 +5,12 @@

part of dart.io;

/// The current system encoding.

+///

+/// This us used for converting from bytes to/from String when

+/// communicating on stdin/stdout and stderr.

Lasse Reichstein Nielsen 2015/06/23 13:08:50 -> stdin, stdout and stderr.

Søren Gjesse 2015/06/24 07:58:26 Done.

+///

+/// On Windows this will use the currently active code page for the

+/// conversion. On all other systems it will always use UTF-8.

const SystemEncoding SYSTEM_ENCODING = const SystemEncoding();

/**