Improve the encoding/decoding to/from system encoding on Windows

runtime/bin/process_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include <process.h>  // NOLINT
 
 #include "bin/builtin.h"
@@ skipping 291 matching lines @@
   CloseProcessPipe(handles3);
   CloseProcessPipe(handles4);
 }
 
 
 static int SetOsErrorMessage(char** os_error_message) {
   int error_code = GetLastError();
   const int kMaxMessageLength = 256;
   wchar_t message[kMaxMessageLength];
   FormatMessageIntoBuffer(error_code, message, kMaxMessageLength);
-  *os_error_message = StringUtils::WideToUtf8(message);
+  *os_error_message = StringUtilsWin::WideToUtf8(message);
   return error_code;
 }
 
 
 // Open an inheritable handle to NUL.
 static HANDLE OpenNul() {
   SECURITY_ATTRIBUTES inherit_handle;
   inherit_handle.nLength = sizeof(SECURITY_ATTRIBUTES);
   inherit_handle.bInheritHandle = TRUE;
   inherit_handle.lpSecurityDescriptor = NULL;
@@ skipping 103 matching lines @@
     stdin_handles_[kReadHandle] = INVALID_HANDLE_VALUE;
     stdin_handles_[kWriteHandle] = INVALID_HANDLE_VALUE;
     stdout_handles_[kReadHandle] = INVALID_HANDLE_VALUE;
     stdout_handles_[kWriteHandle] = INVALID_HANDLE_VALUE;
     stderr_handles_[kReadHandle] = INVALID_HANDLE_VALUE;
     stderr_handles_[kWriteHandle] = INVALID_HANDLE_VALUE;
     exit_handles_[kReadHandle] = INVALID_HANDLE_VALUE;
     exit_handles_[kWriteHandle] = INVALID_HANDLE_VALUE;
 
     // Transform input strings to system format.
-    const wchar_t* system_path = StringUtils::Utf8ToWide(path_);
+    const wchar_t* system_path = StringUtilsWin::Utf8ToWide(path_);
     wchar_t** system_arguments = new wchar_t*[arguments_length];
     for (int i = 0; i < arguments_length; i++) {
-       system_arguments[i] = StringUtils::Utf8ToWide(arguments[i]);
+       system_arguments[i] = StringUtilsWin::Utf8ToWide(arguments[i]);
     }
 
     // Compute command-line length.
     int command_line_length = wcslen(system_path);
     for (int i = 0; i < arguments_length; i++) {
       command_line_length += wcslen(system_arguments[i]);
     }
     // Account for null termination and one space per argument.
     command_line_length += arguments_length + 1;
 
@@ skipping 17 matching lines @@
     free(const_cast<wchar_t*>(system_path));
     for (int i = 0; i < arguments_length; i++) free(system_arguments[i]);
     delete[] system_arguments;
 
     // Create environment block if an environment is supplied.
     environment_block_ = NULL;
     if (environment != NULL) {
       wchar_t** system_environment = new wchar_t*[environment_length];
       // Convert environment strings to system strings.
       for (intptr_t i = 0; i < environment_length; i++) {
-        system_environment[i] = StringUtils::Utf8ToWide(environment[i]);
+        system_environment[i] = StringUtilsWin::Utf8ToWide(environment[i]);
       }
 
       // An environment block is a sequence of zero-terminated strings
       // followed by a block-terminating zero char.
       intptr_t block_size = 1;
       for (intptr_t i = 0; i < environment_length; i++) {
         block_size += wcslen(system_environment[i]) + 1;
       }
       environment_block_ = new wchar_t[block_size];
       intptr_t block_index = 0;
@@ skipping 11 matching lines @@
       environment_block_[block_index++] = '\0';
       ASSERT(block_index == block_size);
       for (intptr_t i = 0; i < environment_length; i++) {
         free(system_environment[i]);
       }
       delete[] system_environment;
     }
 
     system_working_directory_ = NULL;
     if (working_directory_ != NULL) {
-      system_working_directory_ = StringUtils::Utf8ToWide(working_directory_);
+      system_working_directory_ =
+          StringUtilsWin::Utf8ToWide(working_directory_);
     }
 
     attribute_list_ = NULL;
   }
 
 
   ~ProcessStarter() {
     // Deallocate command-line and environment block strings.
     delete[] command_line_;
     delete[] environment_block_;
@@ skipping 522 matching lines @@
       USE(SetConsoleCtrlHandler(SignalHandler, false));
     }
   }
   delete handler;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)