src/handles-inl.h - Issue 1194873004: Revert of Additional HandleScopes to limit Handle consumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles-inl.h

Issue 1194873004: Revert of Additional HandleScopes to limit Handle consumption. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/handles-inl.h

diff --git a/src/handles-inl.h b/src/handles-inl.h

index 3022f288a3919230c955c01c90d5773d731fac6d..34b3f32d960415bd93dd3cbe1c8f5d9178ba8399 100644

--- a/src/handles-inl.h

+++ b/src/handles-inl.h

@@ -92,19 +92,7 @@

HandleScope::~HandleScope() {

-#ifdef DEBUG

- if (FLAG_check_handle_count) {

- int before = NumberOfHandles(isolate_);

- CloseScope(isolate_, prev_next_, prev_limit_);

- int after = NumberOfHandles(isolate_);

- DCHECK(after - before < kCheckHandleThreshold);

- DCHECK(before < kCheckHandleThreshold);

- } else {

-#endif // DEBUG

- CloseScope(isolate_, prev_next_, prev_limit_);

-#ifdef DEBUG

- }

-#endif // DEBUG

+ CloseScope(isolate_, prev_next_, prev_limit_);

}

« no previous file with comments | « src/handles.h ('k') | src/heap/heap.cc » ('j') | no next file with comments »