src/ast.cc - Issue 1194873004: Revert of Additional HandleScopes to limit Handle consumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 1194873004: Revert of Additional HandleScopes to limit Handle consumption. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index aabb8c7bd7ec80c364f3a9aac27d48aa412db297..c9e4c0f21974a8983024e4bc0b4f1415cccc87e1 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -540,10 +540,8 @@

depth_acc = m_literal->depth() + 1;

}

- // New handle scope here, needs to be after BuildContants().

- HandleScope scope(isolate);

Handle<Object> boilerplate_value = GetBoilerplateValue(element, isolate);

if (boilerplate_value->IsTheHole()) {

is_holey = true;

continue;

« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »