Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1194873002: Ship arrow functions (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev, adamk, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship arrow functions R=rossberg@chromium.org LOG=Y BUG=v8:2700 Committed: https://crrev.com/9594cc72eec3ad64506c531106dba6c8fc42bae9 Cr-Commit-Position: refs/heads/master@{#29167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
wingo
Previously landed in https://codereview.chromium.org/1187173004/, reverted because a layout test did "return();" to trigger a devtools ...
5 years, 6 months ago (2015-06-19 12:54:10 UTC) #1
rossberg
lgtm
5 years, 6 months ago (2015-06-19 13:03:50 UTC) #2
rossberg
On 2015/06/19 12:54:10, wingo wrote: > Previously landed in https://codereview.chromium.org/1187173004/, reverted > because a layout ...
5 years, 6 months ago (2015-06-19 13:06:39 UTC) #3
wingo
On 2015/06/19 13:06:39, rossberg wrote: > On 2015/06/19 12:54:10, wingo wrote: > > Previously landed ...
5 years, 6 months ago (2015-06-19 13:11:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194873002/1
5 years, 6 months ago (2015-06-19 19:02:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 19:55:12 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 19:55:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9594cc72eec3ad64506c531106dba6c8fc42bae9
Cr-Commit-Position: refs/heads/master@{#29167}

Powered by Google App Engine
This is Rietveld 408576698