pkg/compiler/lib/src/cps_ir/type_propagation.dart - Issue 1194843002: cps_ir: ForeignCode is not a definition - don't record constness for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1194843002: cps_ir: ForeignCode is not a definition - don't record constness for it. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart

diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart

index cecf42d12e78bc924108bbbc1217600bad0b8d70..c8eda693e758be6a04d79ed50b5ee7314ba58f86 100644

--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart

+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart

@@ -1315,7 +1315,6 @@ class TypePropagationVisitor implements Visitor {

Parameter returnValue = continuation.parameters.first;

setValue(returnValue, nonConstant(node.type));

}

- setValue(node, nonConstant());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »