clang/win: Make diagnostics colored if ansicon is around at runhooks time.

clang/win: Make diagnostics colored if ansicon is around at runhooks time.

BUG=82385
TEST=Run gyp or gn with ansicon active, build. Diagnostics should be colored
in cmd.exe.

Committed: https://crrev.com/59fc7718fefd2c93e1acd94c4d5a405949a0cf10
Cr-Commit-Position: refs/heads/master@{#335394}

[Nico, 2015-06-19 21:50:55]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2015-06-19 21:50:56]

This seems simpler for now than letting ninja do ANSI code interpretation on
Windows. The downside is that people need to manually run ansicon, which
probably ~nobody does.

(Is there some way to detect mintty?)

[hans, 2015-06-19 21:53:59]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2015-06-19 21:54:00]

https://codereview.chromium.org/1194823004/diff/1/build/win/use_ansi_codes.py
File build/win/use_ansi_codes.py (right):

https://codereview.chromium.org/1194823004/diff/1/build/win/use_ansi_codes.py...
build/win/use_ansi_codes.py:5: """Writes if the the terminal is likely to
understand ANSI codes."""
ultra nit: Would "Prints whether" be better?

[scottmg, 2015-06-19 21:58:14]

lgtm

[Nico, 2015-06-19 22:02:49]

thanks!

https://codereview.chromium.org/1194823004/diff/1/build/win/use_ansi_codes.py
File build/win/use_ansi_codes.py (right):

https://codereview.chromium.org/1194823004/diff/1/build/win/use_ansi_codes.py...
build/win/use_ansi_codes.py:5: """Writes if the the terminal is likely to
understand ANSI codes."""
On 2015/06/19 21:53:59, hans wrote:
> ultra nit: Would "Prints whether" be better?

Done.

[Nico, 2015-06-19 22:02:54]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-06-19 22:02:54]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2015-06-19 22:03:51]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-06-19 22:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1194823004/#ps20001
(title: "print")

[commit-bot: I haz the power, 2015-06-19 22:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194823004/20001

[commit-bot: I haz the power, 2015-06-19 22:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 22:18:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2015-06-19 22:20:15]

oh, I was going to ask about that. I think normally just delete the #! on
win/.py.

[Nico, 2015-06-19 22:21:35]

I went with
http://blog.lesc.se/2011/11/how-to-change-file-premissions-in-git.html

On Fri, Jun 19, 2015 at 3:18 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
> )
>
> https://codereview.chromium.org/1194823004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-06-19 22:24:03]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-06-19 22:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1194823004/#ps40001
(title: "chmod")

[commit-bot: I haz the power, 2015-06-19 22:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194823004/40001

[commit-bot: I haz the power, 2015-06-19 22:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 22:38:24]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Nico, 2015-06-19 22:40:14]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-06-19 22:41:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194823004/40001

[commit-bot: I haz the power, 2015-06-19 23:43:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-19 23:44:32]

Patchset 3 (id:??) landed as
https://crrev.com/59fc7718fefd2c93e1acd94c4d5a405949a0cf10
Cr-Commit-Position: refs/heads/master@{#335394}