Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html

Issue 1194813003: Service Worker: Remove ServiceWorker.terminate() method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/interfaces.html ('k') | Source/modules/serviceworkers/ServiceWorker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
diff --git a/LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html b/LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
index 8e1b1f13705f66f4c7179c05183b1e00a6a9487a..83d4fd1ba4a80902f101f19ff7b953057e3de847 100644
--- a/LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
+++ b/LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
@@ -10,12 +10,10 @@ async_test(function(t) {
var scope = 'resources/blank.html';
service_worker_unregister_and_register(t, worker, scope)
.then(t.step_func(function(registration) {
- assert_throws({name: 'InvalidAccessError'}, function() {
- registration.installing.terminate();
- });
+ assert_equals(undefined, registration.installing.terminate);
return service_worker_unregister_and_done(t, scope);
}))
.catch(t.step_func(function(e) { throw e; }));
-}, 'Verify the terminate operation');
+}, 'Verify the terminate method is undefined.');
falken 2015/06/22 06:16:26 IIUC, this test is now redundant with the interfac
jungkees 2015/06/22 06:52:56 Agreed. Removed the test file.
</script>
« no previous file with comments | « LayoutTests/http/tests/serviceworker/interfaces.html ('k') | Source/modules/serviceworkers/ServiceWorker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698