Service Worker: Remove ServiceWorker.terminate() method

Service Worker: Remove ServiceWorker.terminate() method

ServiceWorker interface does not inherit Worker interface anymore (It's still a
type of web workers implementing AbstractWorker.):
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-interface.
This CL removes its terminate() method and update the related layout tests.
Related spec issue: https://github.com/slightlyoff/ServiceWorker/issues/410.

BUG=502934
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197557

[jungkees, 2015-06-19 08:03:22]

jungkee.song@samsung.com changed reviewers:
+ laszlo.gombos@gmail.com

[jungkees, 2015-06-19 08:04:03]

PTAL

[lgombos, 2015-06-19 14:47:53]

l.gombos@samsung.com changed reviewers:
+ l.gombos@samsung.com
- laszlo.gombos@gmail.com

[lgombos, 2015-06-19 14:50:10]

peer review looks good to me

[jungkees, 2015-06-20 05:36:53]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, michaeln@chromium.org,
nhiroki@chromium.org

[jungkees, 2015-06-20 05:40:19]

PTAL As this change suggests removing .terminate() method, it may be more
reasonable to remove serviceworkerobject-terminate.html file too.

[falken, 2015-06-22 06:16:27]

lgtm, I'd prefer you create a bug though for tracking purposes (we can more
easily see which milestone it was removed in)

https://codereview.chromium.org/1194813003/diff/1/LayoutTests/http/tests/serv...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
(right):

https://codereview.chromium.org/1194813003/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html:17: },
'Verify the terminate method is undefined.');
IIUC, this test is now redundant with the interfaces test. Tests have non-zero
maintenance cost, so I'd vote to just remove this test.

[jungkees, 2015-06-22 06:52:56]

Created a bug and removed the test file. Thanks for review!

https://codereview.chromium.org/1194813003/diff/1/LayoutTests/http/tests/serv...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html
(right):

https://codereview.chromium.org/1194813003/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html:17: },
'Verify the terminate method is undefined.');
Agreed. Removed the test file.

[jungkees, 2015-06-22 06:53:21]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2015-06-22 06:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1194813003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-06-22 06:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194813003/20001

[commit-bot: I haz the power, 2015-06-22 08:19:47]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197557