Source/core/css/resolver/FilterOperationResolver.cpp - Issue 1194733002: Adding the 'filter' context attribute to 2D canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 1194733002: Adding the 'filter' context attribute to 2D canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Failure -> ImageOnlyFailure Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/canvas/canvas-filter-units-off-screen.html ('K') | « LayoutTests/fast/canvas/canvas-filter-value-expected.txt ('k') | Source/core/html/canvas/CanvasRenderingContext2D.h » ('j') | Source/core/html/canvas/CanvasRenderingContext2DState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp

index e4ed0327b4f5a6437605524d74cbe521a628d107..a1052037cdbbeb9aba5b91cb358e41b4883d854e 100644

--- a/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -183,7 +183,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS

CSSShadowValue* item = toCSSShadowValue(cssValue);

IntPoint location(item->x->computeLength<int>(conversionData), item->y->computeLength<int>(conversionData));

int blur = item->blur ? item->blur->computeLength<int>(conversionData) : 0;

- Color shadowColor = Color::transparent;

+ Color shadowColor = Color::black;

Stephen White 2015/06/25 18:30:27 Thanks for this catch, BTW!

if (item->color)

shadowColor = state.document().textLinkColors().colorFromPrimitiveValue(item->color.get(), state.style()->color());