Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 11947002: Switch back to deprecated fullscreen APIs. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 11 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Switch back to deprecated fullscreen APIs. This reverts r174754 (and the followup r175255) due to it regressing startup speed. BUG=170189 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -77 lines) Patch
M base/mac/mac_util.mm View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/fullscreen_mac.mm View 2 chunks +47 lines, -47 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/cocoa/fullscreen_window_manager_unittest.mm View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
Nico: this had better improve startup :(
7 years, 11 months ago (2013-01-15 22:47:40 UTC) #1
Mark Mentovai
LGTM although you could hang on to the obvious cleanups like getting rid of the ...
7 years, 11 months ago (2013-01-15 22:55:50 UTC) #2
Avi (use Gerrit)
On 2013/01/15 22:55:50, Mark Mentovai wrote: > LGTM although you could hang on to the ...
7 years, 11 months ago (2013-01-16 01:07:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11947002/1
7 years, 11 months ago (2013-01-16 01:11:11 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 01:11:17 UTC) #5
Presubmit check for 11947002-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698