Adds StyledText

StyledText is just a convenient way to specify a
tree of InlineStyle and InlineText elements.
StyledText builds an Inline that renders the tree.

For example this StyledText object:

  new StyledText(["FOO", [boldLargerStyle, [greenStyle "BAR"], "BAZ"] BORF]);

Renders the same way the following HTML would,
assuming that TextStyles boldLargerStyle and
greenStyle were defined.

<style>
div {
  display: inline;
}
</style>
<p>
  <div>
    FOO
    <div style="font-weight:bold; font-size:larger">
      <div style="color:green">
        BAR
      </div>
      BAZ
    </div>
    BORF
  </div>
</p>

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/14263751a035d7644400e9ded3ccdd9c99703778

[hansmuller, 2015-06-18 19:42:06]

hansmuller@chromium.org changed reviewers:
+ abarth@chromium.org, ianh@google.com

[hansmuller, 2015-06-18 19:49:55]

Patchset #1 (id:1) has been deleted

[hansmuller, 2015-06-18 19:54:04]

Patchset #1 (id:20001) has been deleted

[abarth-chromium, 2015-06-18 20:06:44]

lgtm

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
File sky/examples/widgets/styled_text.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:27: final text = '''
Type?

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:39: final boldStyle = new
TextStyle(fontWeight: bold);
Types please.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
File sky/sdk/lib/widgets/basic.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:386: final elements;
It looks like you intend for this to be a polymorphic variable.  We should mark
it |dynamic| to communicate that.  Also, please add a comment explaining what
sorts of objects the caller can provide.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:388: InlineBase _toInline(elt) {
s/elt/element/

Please use complete words in variable names.

[Hixie, 2015-06-18 20:10:29]

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
File sky/examples/widgets/styled_text.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:1: // Copyright 2015 The Chromium Authors.
All rights reserved.
Add a test that uses this, so we don't break it. See tests/examples/.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:37: final daveStyle = new TextStyle(color:
Indigo[400]);
give these types

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:42: var lineStyle = (name == "Dave") ?
daveStyle : halStyle;
give a type

ditto all other places you use "var".

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:66: List<Component> lines = text
You don't want to be doing this work every time this is built.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:73: for(Component line in lines) {
Space after for.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:75: if (line != lines.last)
children.add(createSeparator());
if condition and statement on different lines.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:84: alignItems:
FlexAlignItems.flexStart));
If the ( is on a separate line, put the ) on a separate line. (applies in
various places)

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
File sky/sdk/lib/widgets/basic.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:384: StyledText({this.elements, String key}) :
super(key: key);
spaces around parameters

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:386: final elements;
need a type

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:389: if (elt is String) {
I'm confused by this. What type is "elements" supposed to be?

[hansmuller, 2015-06-18 21:30:35]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-18 21:30:37]

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
File sky/examples/widgets/styled_text.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:27: final text = '''
On 2015/06/18 20:06:44, abarth wrote:
> Type?

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:37: final daveStyle = new TextStyle(color:
Indigo[400]);
On 2015/06/18 20:10:28, Hixie wrote:
> give these types

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:39: final boldStyle = new
TextStyle(fontWeight: bold);
On 2015/06/18 20:06:43, abarth wrote:
> Types please.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:42: var lineStyle = (name == "Dave") ?
daveStyle : halStyle;
On 2015/06/18 20:10:28, Hixie wrote:
> give a type
> 
> ditto all other places you use "var".
Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:66: List<Component> lines = text
On 2015/06/18 20:10:28, Hixie wrote:
> You don't want to be doing this work every time this is built.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:73: for(Component line in lines) {
On 2015/06/18 20:10:28, Hixie wrote:
> Space after for.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:75: if (line != lines.last)
children.add(createSeparator());
On 2015/06/18 20:10:28, Hixie wrote:
> if condition and statement on different lines.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/examples/widgets/st...
sky/examples/widgets/styled_text.dart:84: alignItems:
FlexAlignItems.flexStart));
On 2015/06/18 20:10:28, Hixie wrote:
> If the ( is on a separate line, put the ) on a separate line. (applies in
> various places)

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
File sky/sdk/lib/widgets/basic.dart (right):

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:384: StyledText({this.elements, String key}) :
super(key: key);
On 2015/06/18 20:10:28, Hixie wrote:
> spaces around parameters

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:386: final elements;
On 2015/06/18 20:06:44, abarth wrote:
> It looks like you intend for this to be a polymorphic variable.  We should
mark
> it |dynamic| to communicate that.  Also, please add a comment explaining what
> sorts of objects the caller can provide.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:386: final elements;
On 2015/06/18 20:06:44, abarth wrote:
> It looks like you intend for this to be a polymorphic variable.  We should
mark
> it |dynamic| to communicate that.  Also, please add a comment explaining what
> sorts of objects the caller can provide.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:388: InlineBase _toInline(elt) {
On 2015/06/18 20:06:44, abarth wrote:
> s/elt/element/
> 
> Please use complete words in variable names.

Done.

https://codereview.chromium.org/1194693002/diff/40001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:389: if (elt is String) {
On 2015/06/18 20:10:29, Hixie wrote:
> I'm confused by this. What type is "elements" supposed to be?

Sorry to be opaque. I added a comment:

  // elements ::= "string" | [<text-style> <elements>*]
  // Where "string" is text to display and text-style is an instance of
  // TextStyle. The text-style applies to all of the elements that follow.

[hansmuller1, 2015-06-18 21:35:33]

Committed patchset #2 (id:60001) manually as
14263751a035d7644400e9ded3ccdd9c99703778 (presubmit successful).

[Hixie, 2015-06-18 22:32:24]

https://codereview.chromium.org/1194693002/diff/60001/sky/sdk/lib/widgets/bas...
File sky/sdk/lib/widgets/basic.dart (right):

https://codereview.chromium.org/1194693002/diff/60001/sky/sdk/lib/widgets/bas...
sky/sdk/lib/widgets/basic.dart:384: // elements ::= "string" | [<text-style>
<elements>*]
I think it'd be better to have this only support TextStyle objects. If you want
unstyled text, you'd just use Text().