Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issue 1194673005: Fix stack-use-after-return in ~ScopeRecorder (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix stack-use-after-return in ~ScopeRecorder We should not save the reference to a temporary DisplayItemClientWrapper in ScopeRecorder. BUG=501721 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/paint/ScopeRecorder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Xianzhu
4 years, 10 months ago (2015-06-18 19:28:05 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-18 19:30:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194673005/1
4 years, 10 months ago (2015-06-18 19:31:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59602)
4 years, 10 months ago (2015-06-18 21:10:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194673005/1
4 years, 10 months ago (2015-06-18 21:16:11 UTC) #9
Xianzhu
4 years, 10 months ago (2015-06-18 21:18:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 197396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698