Issue 1194673002: Revert of Replace ad-hoc weakness in transition array with WeakCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1194673002: Revert of Replace ad-hoc weakness in transition array with WeakCell. (Closed)

Created:
5 years, 6 months ago by ulan

Modified:
5 years, 6 months ago

Reviewers:
Hannes Payer (out of office), Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Replace ad-hoc weakness in transition array with WeakCell. (patchset #5 id:80001 of https://codereview.chromium.org/1157943003/) Reason for revert: Breaks descriptor array clearing. Original issue's description: > Replace ad-hoc weakness in transition array with WeakCell. > > BUG= > > Committed: https://crrev.com/885455e99de817f86a0b5df2dc0d932cfc179749 > Cr-Commit-Position: refs/heads/master@{#29083} TBR=jkummerow@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7bba17bcdbf724993dac6ba8f6c7953fd9712df3 Cr-Commit-Position: refs/heads/master@{#29121}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -78 lines)			Patch
M	src/heap/mark-compact.cc	View	1 chunk	+17 lines, -31 lines	0 comments	Download
M	src/heap/objects-visiting.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/objects-visiting-inl.h	View	2 chunks	+22 lines, -0 lines	0 comments	Download
M	src/transitions.h	View	4 chunks	+7 lines, -12 lines	0 comments	Download
M	src/transitions.cc	View	8 chunks	+20 lines, -17 lines	0 comments	Download
M	src/transitions-inl.h	View	4 chunks	+9 lines, -18 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

Created Revert of Replace ad-hoc weakness in transition array with WeakCell.

5 years, 6 months ago (2015-06-18 15:51:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194673002/1

5 years, 6 months ago (2015-06-18 15:51:44 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-18 15:52:13 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7bba17bcdbf724993dac6ba8f6c7953fd9712df3
Cr-Commit-Position: refs/heads/master@{#29121}