Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1194623005: Fix ellipsis width when font has no ellipsis glyph (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix ellipsis width when font has no ellipsis glyph BUG=502051 TEST=fast/text/ellipsis-platform-font-change.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197422

Patch Set 1 #

Patch Set 2 : NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Xianzhu
Will rebaseline tests after the try jobs finish.
4 years, 10 months ago (2015-06-18 22:40:24 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-18 23:24:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623005/20001
4 years, 10 months ago (2015-06-19 01:09:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/38860)
4 years, 10 months ago (2015-06-19 01:18:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623005/20001
4 years, 10 months ago (2015-06-19 01:23:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/38864)
4 years, 10 months ago (2015-06-19 01:32:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623005/20001
4 years, 10 months ago (2015-06-19 01:54:06 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 02:31:47 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197422

Powered by Google App Engine
This is Rietveld 408576698