Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1194623003: cc: Remove contents_texture_manager from LayerTreeHost(Impl) and proxy. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, ccameron, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove contents_texture_manager from LayerTreeHost(Impl) and proxy. This removes the PrioritizedResourceManager from the LayerTreeHost and calls to it from memory policy changes etc. This left no callers to SetContentsTexturesPurged, so removed that concept from CanDraw and from LayerTreeImpl. R=enne, vmpstr BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f104c8c727b6b9f51f575991986f62a859eb6854 Cr-Commit-Position: refs/heads/master@{#335202}

Patch Set 1 #

Patch Set 2 : contentstexturemanager: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -474 lines) Patch
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 3 chunks +0 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 4 chunks +0 lines, -47 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 6 chunks +5 lines, -33 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 6 chunks +1 line, -122 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 chunks +1 line, -74 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 3 chunks +0 lines, -24 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 5 chunks +0 lines, -40 lines 0 comments Download
M cc/trees/thread_proxy.h View 3 chunks +0 lines, -8 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 9 chunks +3 lines, -98 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
danakj
5 years, 6 months ago (2015-06-18 22:29:20 UTC) #1
danakj
5 years, 6 months ago (2015-06-18 22:29:41 UTC) #2
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-18 23:01:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623003/1
5 years, 6 months ago (2015-06-18 23:06:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623003/20001
5 years, 6 months ago (2015-06-19 00:20:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/99941)
5 years, 6 months ago (2015-06-19 00:27:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623003/20001
5 years, 6 months ago (2015-06-19 00:40:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/83192) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-19 00:53:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623003/20001
5 years, 6 months ago (2015-06-19 00:54:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/83198)
5 years, 6 months ago (2015-06-19 01:04:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194623003/20001
5 years, 6 months ago (2015-06-19 02:50:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 03:46:38 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 03:47:22 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f104c8c727b6b9f51f575991986f62a859eb6854
Cr-Commit-Position: refs/heads/master@{#335202}

Powered by Google App Engine
This is Rietveld 408576698