Record event activity to the extension activity log.

chrome/browser/extensions/api/web_request/web_request_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 1060 matching lines @@
     // Filter out the optional keys that this listener didn't request.
     scoped_ptr<ListValue> args_filtered(args.DeepCopy());
     DictionaryValue* dict = NULL;
     CHECK(args_filtered->GetDictionary(0, &dict) && dict);
     if (!((*it)->extra_info_spec & ExtraInfoSpec::REQUEST_HEADERS))
       dict->Remove(keys::kRequestHeadersKey, NULL);
     if (!((*it)->extra_info_spec & ExtraInfoSpec::RESPONSE_HEADERS))
       dict->Remove(keys::kResponseHeadersKey, NULL);
 
     extensions::EventRouter::DispatchEvent(
-        (*it)->ipc_sender.get(), (*it)->extension_id, (*it)->sub_event_name,
+        (*it)->ipc_sender.get(), static_cast<Profile*>(profile),

[Matt Perry, 2013/01/25 21:24:17]

There's a reason that |profile| is a void* - so you don't end up dereferencing
it like this :). This is on the IO thread. Even though you're pinging it over to
the UI thread eventually, it's not safe because there's no guarantee the Profile
hasn't been deleted by the time you dereference it.

See
https://code.google.com/p/chromium/codesearch#chrome/src/chrome/browser/net/c...
for the (hacky) way to handle this case. I'd prefer you keep the profile as a
void* until it makes its way all the way to the UI thread.

[mvrable, 2013/01/28 16:27:36]

Fixed I think--does the new version look all right?

+        (*it)->extension_id, (*it)->sub_event_name,
         args_filtered.Pass(), GURL(),
         extensions::EventRouter::USER_GESTURE_UNKNOWN,
         extensions::EventFilteringInfo());
     if ((*it)->extra_info_spec &
         (ExtraInfoSpec::BLOCKING | ExtraInfoSpec::ASYNC_BLOCKING)) {
       (*it)->blocked_requests.insert(request->identifier());
       ++num_handlers_blocking;
 
       request->SetLoadStateParam(
           l10n_util::GetStringFUTF16(IDS_LOAD_STATE_PARAMETER_EXTENSION,
@@ skipping 915 matching lines @@
       } else if ((*it)->name().find("AdBlock") != std::string::npos) {
         adblock = true;
       } else {
         other = true;
       }
     }
   }
 
   host->Send(new ExtensionMsg_UsingWebRequestAPI(adblock, adblock_plus, other));
 }