Record event activity to the extension activity log.

chrome/browser/extensions/activity_log.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 18 matching lines @@
 class Extension;
 
 // A utility for tracing interesting activity for each extension.
 // It writes to an ActivityDatabase on a separate thread to record the activity.
 class ActivityLog : public ProfileKeyedService,
                     public TabHelper::ScriptExecutionObserver {
  public:
   enum Activity {
     ACTIVITY_EXTENSION_API_CALL,   // Extension API invocation is called.
     ACTIVITY_EXTENSION_API_BLOCK,  // Extension API invocation is blocked.
-    ACTIVITY_CONTENT_SCRIPT        // Content script is executing.
+    ACTIVITY_CONTENT_SCRIPT,       // Content script is executing.
+    ACTIVITY_EVENT_DISPATCH,       // Event sent to listener in extension.

[Eric Dingle, 2013/01/24 16:16:34]

Looking back, it would have been nice if those first two enum values were just
ACTIVITY_API_(CALL|BLOCK). Oh well. Clean up change for later.

   };
 
   // Observers can listen for activity events.
   class Observer {
    public:
     virtual void OnExtensionActivity(
         const Extension* extension,
         Activity activity,
         const std::string& message) = 0;
   };
@@ skipping 10 matching lines @@
   void AddObserver(const Extension* extension, Observer* observer);
   void RemoveObserver(const Extension* extension,
                       Observer* observer);
 
   // Check for the existence observer list by extension_id.
   bool HasObservers(const Extension* extension) const;
 
   // Log a successful API call made by an extension.
   // This will create an APIAction for storage in the database.
   void LogAPIAction(const Extension* extension,
-                    const std::string& name,    // e.g., chrome.tabs.get
+                    const std::string& name,    // e.g., tabs.get
                     const ListValue* args,      // the argument values e.g. 46
                     const std::string& extra);  // any extra logging info
 
+  // Log an event notification delivered to an extension.
+  // This will crate an APIActiion for storage in the database.

[Eric Dingle, 2013/01/24 16:16:34]

*create
*APIAction

[mvrable, 2013/01/24 18:12:31]

Done.

+  void LogEventAction(const Extension* extension,
+                      const std::string& name,    // e.g., tabs.onUpdate
+                      const ListValue* args,      // arguments to the callback

[Eric Dingle, 2013/01/24 16:16:34]

All comments should begin capitalized and end with a period.

[mvrable, 2013/01/24 18:12:31]

Is that necessary even here?  There isn't much room at the end of the line.  We
could put these comments on a separate line, though the style guide mentions
"Shorter comments, such as comments at the end of a line of code, can sometimes
be less formal, but you should be consistent with your style"
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...).
 But I'll change these if you want.

[Eric Dingle, 2013/01/24 18:56:56]

Fine to leave as is.

On 2013/01/24 18:12:31, mvrable wrote:

+                      const std::string& extra);  // any extra logging info
+
   // Log a blocked API call made by an extension.
   // This will create a BlockedAction for storage in the database.
   void LogBlockedAction(const Extension* extension,
-                        const std::string& blocked_call,  // eg chrome.tabs.get
+                        const std::string& blocked_call,  // eg tabs.get

[Eric Dingle, 2013/01/24 16:16:34]

Be consistent with your e.g.,

[mvrable, 2013/01/24 18:12:31]

Done.

                         const ListValue* args,            // argument values
                         const char* reason,               // why it's blocked
                         const std::string& extra);        // extra logging info
 
   // Log an interaction between an extension and a URL.
   // This will create a UrlAction for storage in the database.
   // The technical message might be the list of content scripts that have been
   // injected, or the DOM API call; it's what's shown under "More".
   void LogUrlAction(const Extension* extension,
                     const UrlAction::UrlActionType verb,  // eg XHR
@@ skipping 92 matching lines @@
   virtual bool ServiceRedirectedInIncognito() const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(ActivityLogFactory);
 };
 
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_