Record event activity to the extension activity log.

chrome/browser/extensions/api_actions.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include "base/logging.h"
 #include "chrome/browser/extensions/api_actions.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
 const char* APIAction::kTableName = "activitylog_apis";
 const char* APIAction::kTableStructure = "("
     "extension_id LONGVARCHAR NOT NULL, "
     "time INTEGER NOT NULL, "
+    "api_category LONGVARCHAR NOT NULL, "

[felt, 2013/01/22 23:02:11]

I think that the schema change is good.

     "api_action_type LONGVARCHAR NOT NULL, "
     "target_type LONGVARCHAR NOT NULL, "
     "api_call LONGVARCHAR NOT NULL, "
     "extra LONGVARCHAR NOT NULL)";
 
 APIAction::APIAction(const std::string& extension_id,
                      const base::Time& time,
+                     const APICategory category,
                      const APIActionType verb,
                      const APITargetType target,
                      const std::string& api_call,
                      const std::string& extra)
     : extension_id_(extension_id),
       time_(time),
+      category_(category),
       verb_(verb),
       target_(target),
       api_call_(api_call),
       extra_(extra) { }
 
 APIAction::~APIAction() {
 }
 
 void APIAction::Record(sql::Connection* db) {
   std::string sql_str = "INSERT INTO " + std::string(kTableName)
-      + " (extension_id, time, api_action_type, target_type, api_call, extra)"
-      " VALUES (?,?,?,?,?,?)";
+      + " (extension_id, time, api_category, api_action_type, target_type,"
+      " api_call, extra) VALUES (?,?,?,?,?,?,?)";

[felt, 2013/01/22 23:02:11]

What happens if you had the table created with the old version (without
api_category) and then run this code? (You'll be missing a column-- probably
leading to a crash here.) Perhaps it would make sense for this change (and any
future schema change) to have a check in ActivityDatabase->InitializeTable to
make sure all the columns are present. Maybe SQL::Connection gives a built in
way to do this? 

[mvrable, 2013/01/23 16:54:07]

I've added some code to update the database schema if the new column is missing.
 I've put this in a new method in api_actions.cc, but if you'd rather I can
inline the code in activity_database.cc.

   sql::Statement statement(db->GetCachedStatement(
       sql::StatementID(SQL_FROM_HERE), sql_str.c_str()));
   statement.BindString(0, extension_id_);
   statement.BindInt64(1, time_.ToInternalValue());
-  statement.BindString(2, VerbAsString());
-  statement.BindString(3, TargetAsString());
-  statement.BindString(4, api_call_);
-  statement.BindString(5, extra_);
+  statement.BindString(2, CategoryAsString());
+  statement.BindString(3, VerbAsString());
+  statement.BindString(4, TargetAsString());
+  statement.BindString(5, api_call_);
+  statement.BindString(6, extra_);
 
   if (!statement.Run())
     LOG(ERROR) << "Activity log database I/O failed: " << sql_str;
 }
 
 std::string APIAction::PrettyPrintFori18n() {
   // TODO(felt): implement this for real when the UI is redesigned.
   return PrettyPrintForDebug();
 }
 
 std::string APIAction::PrettyPrintForDebug() {
   // TODO(felt): implement this for real when the UI is redesigned.
-  return "ID: " + extension_id_ + ", VERB: " + VerbAsString() +
-      ", TARGET: " + TargetAsString() + ", API: " + api_call_;
+  return "ID: " + extension_id_ + + ", CATEGORY: " + CategoryAsString() +
+      ", VERB: " + VerbAsString() + ", TARGET: " + TargetAsString() +
+      ", API: " + api_call_;
+}
+
+std::string APIAction::CategoryAsString() const {
+  switch (category_) {
+    case CALL:
+      return "CALL";
+    case EVENT_CALLBACK:
+      return "EVENT_CALLBACK";
+    default:
+      return "UNKNOWN_CATEGORY";
+  }
 }
 
 std::string APIAction::VerbAsString() const {
   switch (verb_) {
     case READ:
       return "READ";
     case MODIFIED:
       return "MODIFIED";
     case DELETED:
       return "DELETED";
@@ skipping 24 matching lines @@
       return "BROWSER_ACTION";
     case NOTIFICATION:
       return "NOTIFICATION";
     case OMNIBOX:
       return "OMNIBOX";
     default:
       return "UNKNOWN_TARGET";
   }
 }
 
+APIAction::APICategory APIAction::StringAsCategory(
+    const std::string& str) {
+  if (str == "CALL") {
+    return CALL;
+  } else if (str == "EVENT_CALLBACK") {
+    return EVENT_CALLBACK;
+  } else {
+    return UNKNOWN_CATEGORY;
+  }
+}
+
 APIAction::APIActionType APIAction::StringAsActionType(
     const std::string& str) {
   if (str == "READ") {
     return READ;
   } else if (str == "MODIFIED") {
     return MODIFIED;
   } else if (str == "DELETED") {
     return DELETED;
   } else if (str == "ADDED") {
     return ADDED;
@@ skipping 26 matching lines @@
     return NOTIFICATION;
   } else if (str == "OMNIBOX" || str == "omnibox") {
     return OMNIBOX;
   } else {
     return UNKNOWN_TARGET;
   }
 }
 
 }  // namespace extensions