Remove old cloud policy code.

Remove old cloud policy code.

The old framework has been abandoned in favor of a more flexible rewrite
which is already being used for the desktop cloud policy implementation.
Chrome OS has switched over with M25, so it's time to remove the old
code.

BUG=chromium:108928
TEST=Still compiles and passes tests.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178283

[Mattias Nissler (ping if slow), 2013-01-16 16:22:46]

Hi Joao, I think you might like this :)

This also removes the PyAuto interface, which was broken since the switch
anyways, and nobody noticed ;)

[Joao da Silva, 2013-01-17 09:38:05]

policy/proto/old_generic_format.proto can also be removed now. It's referenced
in chrome/app/policy/cloud_policy_codegen.gyp.

delayed_work_scheduler.* can be removed too.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/automation/...
File chrome/browser/automation/testing_automation_provider.h (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/automation/...
chrome/browser/automation/testing_automation_provider.h:1490: IPC::Message*
reply_message);
Remove these calls from chrome/test/pyautolib/pyauto.py too.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:539:
g_browser_process->browser_policy_connector();
Move next to where it's first used now.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc
(left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc:35:
const int kLockRetryTimeoutMs = 10 * 60 * 1000;  // 10 minutes.
These constants aren't needed anymore.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/oauth1_login_manager.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/oauth1_login_manager.cc:10: #include
"chrome/browser/policy/browser_policy_connector.h"
Not used anymore

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/version_info_updater.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/version_info_updater.cc:136: UpdateVersionLabel();
FWIW, UpdateVersionLabel() doesn't use enterprise_domain_text_.
enterprise_domain_text_ is not even used at all.

OnEnterpriseInfoUpdated() still ends up sending its argument to
display_manager.js.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.cc (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:28: #include
"chrome/common/pref_names.h"
Not used

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:30: #include
"content/public/browser/notification_source.h"
These 2 not used

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.h (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.h:15: #include
"chrome/browser/policy/enterprise_install_attributes.h"
This can be forward-declared now

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_browsertest.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_browsertest.cc:290: INSTANTIATE_TEST_CASE_P(
There's no need to make these test parameterized now, care to change to TEST_Fs?
:-)

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/user...
File chrome/browser/policy/user_policy_token_cache.h (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/user...
chrome/browser/policy/user_policy_token_cache.h:18: class UserPolicyTokenLoader
Rename this file to user_policy_token_loader.h?

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/prefs/brows...
File chrome/browser/prefs/browser_prefs.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/prefs/brows...
chrome/browser/prefs/browser_prefs.cc:177:
policy::CloudPolicySubsystem::RegisterPrefs(local_state);
This was registering kDevicePolicyRefreshRate and kUserPolicyRefreshRate, they
have to be registered somewhere else now. At the connector?

https://codereview.chromium.org/11946017/diff/9001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:1348: 'browser/policy/delayed_work_scheduler.h',
This can be removed too.

[Mattias Nissler (ping if slow), 2013-01-22 10:31:39]

Ready for another round

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/automation/...
File chrome/browser/automation/testing_automation_provider.h (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/automation/...
chrome/browser/automation/testing_automation_provider.h:1490: IPC::Message*
reply_message);
On 2013/01/17 09:38:05, Joao da Silva wrote:
> Remove these calls from chrome/test/pyautolib/pyauto.py too.

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:539:
g_browser_process->browser_policy_connector();
On 2013/01/17 09:38:05, Joao da Silva wrote:
> Move next to where it's first used now.

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc
(left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc:35:
const int kLockRetryTimeoutMs = 10 * 60 * 1000;  // 10 minutes.
On 2013/01/17 09:38:05, Joao da Silva wrote:
> These constants aren't needed anymore.

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/oauth1_login_manager.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/oauth1_login_manager.cc:10: #include
"chrome/browser/policy/browser_policy_connector.h"
On 2013/01/17 09:38:05, Joao da Silva wrote:
> Not used anymore

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/version_info_updater.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/version_info_updater.cc:136: UpdateVersionLabel();
On 2013/01/17 09:38:05, Joao da Silva wrote:
> FWIW, UpdateVersionLabel() doesn't use enterprise_domain_text_.
> enterprise_domain_text_ is not even used at all.
> 
> OnEnterpriseInfoUpdated() still ends up sending its argument to
> display_manager.js.

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.cc (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:28: #include
"chrome/common/pref_names.h"
On 2013/01/17 09:38:05, Joao da Silva wrote:
> Not used

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:30: #include
"content/public/browser/notification_source.h"
On 2013/01/17 09:38:05, Joao da Silva wrote:
> These 2 not used

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.h (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.h:15: #include
"chrome/browser/policy/enterprise_install_attributes.h"
On 2013/01/17 09:38:05, Joao da Silva wrote:
> This can be forward-declared now

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_browsertest.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_browsertest.cc:290: INSTANTIATE_TEST_CASE_P(
On 2013/01/17 09:38:05, Joao da Silva wrote:
> There's no need to make these test parameterized now, care to change to
TEST_Fs?
> :-)

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/user...
File chrome/browser/policy/user_policy_token_cache.h (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/policy/user...
chrome/browser/policy/user_policy_token_cache.h:18: class UserPolicyTokenLoader
On 2013/01/17 09:38:05, Joao da Silva wrote:
> Rename this file to user_policy_token_loader.h?

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/prefs/brows...
File chrome/browser/prefs/browser_prefs.cc (left):

https://codereview.chromium.org/11946017/diff/9001/chrome/browser/prefs/brows...
chrome/browser/prefs/browser_prefs.cc:177:
policy::CloudPolicySubsystem::RegisterPrefs(local_state);
On 2013/01/17 09:38:05, Joao da Silva wrote:
> This was registering kDevicePolicyRefreshRate and kUserPolicyRefreshRate, they
> have to be registered somewhere else now. At the connector?

Done.

https://codereview.chromium.org/11946017/diff/9001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/11946017/diff/9001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:1348: 'browser/policy/delayed_work_scheduler.h',
On 2013/01/17 09:38:05, Joao da Silva wrote:
> This can be removed too.

Done.

[Joao da Silva, 2013-01-22 12:39:03]

lgtm

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:120: if (delegate_) {
if (delegate_ && !domain_name.empty()) {  ... }

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/prefs/brow...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/prefs/brow...
chrome/browser/prefs/browser_prefs.cc:182:
policy::BrowserPolicyConnector::RegisterPrefs(local_state);
nitty nit: order

[Mattias Nissler (ping if slow), 2013-01-22 14:14:52]

+Ben for OWNERS approval of:

chrome/browser/automation, chrome/test/pyautolib: The code is broken since
before the 25 branch and nobody noticed :)
chrome/common
chrome/browser/ui
chrome/*.gypi

+Nikita for chrome/browser/chromeos OWNERS approval.

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/version_info_updater.cc:120: if (delegate_) {
On 2013/01/22 12:39:03, Joao da Silva wrote:
> if (delegate_ && !domain_name.empty()) {  ... }

Done.

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/prefs/brow...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/11946017/diff/16001/chrome/browser/prefs/brow...
chrome/browser/prefs/browser_prefs.cc:182:
policy::BrowserPolicyConnector::RegisterPrefs(local_state);
On 2013/01/22 12:39:03, Joao da Silva wrote:
> nitty nit: order

Done.

[Nikita (slow), 2013-01-22 14:21:25]

lgtm

[Ben Goodger (Google), 2013-01-22 22:16:15]

lgtm yay

[commit-bot: I haz the power, 2013-01-23 10:32:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/11946017/24004

[commit-bot: I haz the power, 2013-01-23 12:15:30]

Change committed as 178283