Cleaned up a few analyzer warnings

Cleaned up a few analyzer warnings

R=ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/da1f9e780f31d6977a8407863d2635f3ec31bba1

[hansmuller, 2015-06-17 17:00:00]

hansmuller@chromium.org changed reviewers:
+ ianh@google.com

[hansmuller, 2015-06-17 17:03:10]

Patchset #1 (id:1) has been deleted

[hansmuller, 2015-06-17 17:04:49]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-17 17:04:50]

PTAL

[Hixie, 2015-06-17 17:11:17]

lgtm

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/p...
File sky/sdk/lib/rendering/paragraph.dart (right):

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/p...
sky/sdk/lib/rendering/paragraph.dart:127: assert(style != null && children !=
null);
this is fine but as a general rule I recommend splitting such asserts into two
asserts, so that when one fires, you know which side of the expression was to
blame.

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/widgets/wid...
File sky/sdk/lib/widgets/widget.dart (right):

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/widgets/wid...
sky/sdk/lib/widgets/widget.dart:113: !(oldNode as
Component)._disqualifiedFromEverAppearingAgain);
this warning is a bug in the analyzer, you should leave it as it was.

[hansmuller, 2015-06-17 17:35:39]

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/p...
File sky/sdk/lib/rendering/paragraph.dart (right):

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/p...
sky/sdk/lib/rendering/paragraph.dart:127: assert(style != null && children !=
null);
On 2015/06/17 17:11:17, Hixie wrote:
> this is fine but as a general rule I recommend splitting such asserts into two
> asserts, so that when one fires, you know which side of the expression was to
> blame.

Done.

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/widgets/wid...
File sky/sdk/lib/widgets/widget.dart (right):

https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/widgets/wid...
sky/sdk/lib/widgets/widget.dart:113: !(oldNode as
Component)._disqualifiedFromEverAppearingAgain);
On 2015/06/17 17:11:17, Hixie wrote:
> this warning is a bug in the analyzer, you should leave it as it was.

Done.

[hansmuller1, 2015-06-17 17:35:57]

Committed patchset #2 (id:40001) manually as
da1f9e780f31d6977a8407863d2635f3ec31bba1 (presubmit successful).