Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1194583002: Cleaned up a few analyzer warnings (Closed)

Created:
5 years, 6 months ago by hansmuller1
Modified:
5 years, 6 months ago
Reviewers:
hansmuller, Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 4

Patch Set 2 : changes per review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M sky/sdk/lib/rendering/paragraph.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
hansmuller
PTAL
5 years, 6 months ago (2015-06-17 17:04:50 UTC) #4
Hixie
lgtm https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/paragraph.dart File sky/sdk/lib/rendering/paragraph.dart (right): https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/paragraph.dart#newcode127 sky/sdk/lib/rendering/paragraph.dart:127: assert(style != null && children != null); this ...
5 years, 6 months ago (2015-06-17 17:11:17 UTC) #5
hansmuller
https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/paragraph.dart File sky/sdk/lib/rendering/paragraph.dart (right): https://codereview.chromium.org/1194583002/diff/20001/sky/sdk/lib/rendering/paragraph.dart#newcode127 sky/sdk/lib/rendering/paragraph.dart:127: assert(style != null && children != null); On 2015/06/17 ...
5 years, 6 months ago (2015-06-17 17:35:39 UTC) #6
hansmuller1
5 years, 6 months ago (2015-06-17 17:35:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
da1f9e780f31d6977a8407863d2635f3ec31bba1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698