Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(223)

Issue 1194563003: Don't crash in V8Window::openMethodCustom when called on RemoteDOMWindow. (Closed)

Created:
4 years, 10 months ago by alexmos
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg, dcheng, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't crash in V8Window::openMethodCustom when called on RemoteDOMWindow. Currently, openMethodCustom assumes it's called on a LocalDOMWindow, which may not be true in --site-per-process mode. This CL moves the cast to LocalDOMWindow to be done after the BindingSecurity check, which should throw exceptions when called on RemoteDOMWindows (since those are always cross-origin). BUG=501414, 477150 TEST=http/tests/security/xss-exception.html with --site-per-process Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alexmos
haraken@: PTAL.
4 years, 10 months ago (2015-06-17 22:00:29 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-17 22:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194563003/1
4 years, 10 months ago (2015-06-17 22:07:34 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 23:31:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197295

Powered by Google App Engine
This is Rietveld 408576698