Source/core/layout/LayoutPart.cpp - Issue 1194473003: Make updateLayoutAndStyleForPainting() O(N) in terms of frame number in LayoutView::hitTest()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutPart.cpp

Issue 1194473003: Make updateLayoutAndStyleForPainting() O(N) in terms of frame number in LayoutView::hitTest() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebasae layout test result because the order of the when the tracing runs changed Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutPart.cpp

diff --git a/Source/core/layout/LayoutPart.cpp b/Source/core/layout/LayoutPart.cpp

index 7ab21508f7787e10b547ac24aa807cbbd2dfe037..cae3fb991c9aa9970659e306f186f9fd9452063c 100644

--- a/Source/core/layout/LayoutPart.cpp

+++ b/Source/core/layout/LayoutPart.cpp

@@ -170,7 +170,8 @@ bool LayoutPart::nodeAtPoint(HitTestResult& result, const HitTestLocation& locat

HitTestRequest newHitTestRequest(result.hitTestRequest().type() | HitTestRequest::ChildFrameHitTest);

HitTestResult childFrameResult(newHitTestRequest, newHitTestLocation);

- bool isInsideChildFrame = childRoot->hitTest(childFrameResult);

+ // The frame's layout and style must be up-to-date if we reach here.

+ bool isInsideChildFrame = childRoot->hitTestNoLayoutAndStyleUpdate(childFrameResult);

if (result.hitTestRequest().listBased()) {

result.append(childFrameResult);

« no previous file with comments | « LayoutTests/inspector/tracing/hit-test-expected.txt ('k') | Source/core/layout/LayoutView.h » ('j') | no next file with comments »