Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1194423008: Revert of Audio and video decoders for MediaCodecPlayer (Closed)

Created:
5 years, 6 months ago by Stephen Chennney
Modified:
5 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Audio and video decoders for MediaCodecPlayer (patchset #11 id:200001 of https://codereview.chromium.org/1176993005/) Reason for revert: Failing tests. Specifically, media_unittests and org.chromium.android_webview.test.MediaAccessPermissionRequestTest#testGrantAccess https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/26686 Original issue's description: > Audio and video decoders for MediaCodecPlayer > > This is a prerequisite for MediaCodecPlayer (to be committed later). > > Each decoder controls the queue of incoming access units and the > Android MediaCodec object through the instance of MediaCodecBridge. > The decoder owns a dedicated thread (Decoder thread) to access the > MediaCodecBridge. The manipulations with MediaCodec buffers, both > input and output, as well the rendering happen on this one thread. > > For discussion see https://codereview.chromium.org/1128383003/ > > BUG=407577 > > Committed: https://crrev.com/d472a7860ac521ef72c53c9bb04926d4747e0b01 > Cr-Commit-Position: refs/heads/master@{#335618} TBR=qinmin@chromium.org,wolenetz@chromium.org,watk@chromium.org,liberato@chromium.org,timav@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=407577 Committed: https://crrev.com/c4c79ad711ae50cee92209c5d4423711de018d2a Cr-Commit-Position: refs/heads/master@{#335661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2366 lines) Patch
M media/base/android/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 1 chunk +0 lines, -7 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D media/base/android/media_codec_audio_decoder.h View 1 chunk +0 lines, -91 lines 0 comments Download
D media/base/android/media_codec_audio_decoder.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D media/base/android/media_codec_decoder.h View 1 chunk +0 lines, -283 lines 0 comments Download
D media/base/android/media_codec_decoder.cc View 1 chunk +0 lines, -598 lines 0 comments Download
D media/base/android/media_codec_decoder_unittest.cc View 1 chunk +0 lines, -519 lines 0 comments Download
D media/base/android/media_codec_video_decoder.h View 1 chunk +0 lines, -111 lines 0 comments Download
D media/base/android/media_codec_video_decoder.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D media/base/android/test_data_factory.h View 1 chunk +0 lines, -68 lines 0 comments Download
D media/base/android/test_data_factory.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
D media/test/data/h264-320x180-frame-0 View Binary file 0 comments Download
D media/test/data/h264-320x180-frame-1 View Binary file 0 comments Download
D media/test/data/h264-320x180-frame-2 View Binary file 0 comments Download
D media/test/data/h264-320x180-frame-3 View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen Chennney
Created Revert of Audio and video decoders for MediaCodecPlayer
5 years, 6 months ago (2015-06-23 13:27:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194423008/1
5 years, 6 months ago (2015-06-23 13:28:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 13:29:41 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 13:30:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4c79ad711ae50cee92209c5d4423711de018d2a
Cr-Commit-Position: refs/heads/master@{#335661}

Powered by Google App Engine
This is Rietveld 408576698