Don't check for USE_CREDENTIALS permission on Android M.

Don't check for USE_CREDENTIALS permission on Android M.

BUG=501435
Committed: https://crrev.com/d74b322a46041b6838b3e0f36c0489bc9bca8554
Cr-Commit-Position: refs/heads/master@{#335585}

[Bernhard Bauer, 2015-06-22 14:08:38]

bauerb@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Bernhard Bauer, 2015-06-22 14:09:57]

bauerb@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Bernhard Bauer, 2015-06-22 14:09:57]

Please review.

[Ted C, 2015-06-22 15:17:29]

lgtm

[Yaron, 2015-06-22 20:17:11]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2015-06-22 20:17:17]

The CQ bit was unchecked by yfriedman@chromium.org

[Yaron, 2015-06-22 20:21:05]

Khushal and Tommy looked at this as part crbug.com/499399

I think at the time it was still going to be configurable but now it's not so
lgtm unless I'm missing something

[nyquist, 2015-06-22 21:06:13]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2015-06-22 21:06:14]

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/BuildInfo.java:130: public static
boolean isMncOrLater() {
Optional nit: I thought it was supposed to be called Android M for now, not
'MNC'?

https://codereview.chromium.org/1194423002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
(right):

https://codereview.chromium.org/1194423002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java:202: return
false;
Optional nit: Feel free to move this early out to the previous line.

[Bernhard Bauer, 2015-06-22 21:16:08]

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/BuildInfo.java:130: public static
boolean isMncOrLater() {
On 2015/06/22 21:06:13, nyquist (OOO - back 6-29) wrote:
> Optional nit: I thought it was supposed to be called Android M for now, not
> 'MNC'?

TBH, I called it that just because "MncOrLater" looked more readable to me than
the single M in "MOrLater"... 0:-)

https://codereview.chromium.org/1194423002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
(right):

https://codereview.chromium.org/1194423002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java:202: return
false;
On 2015/06/22 21:06:13, nyquist (OOO - back 6-29) wrote:
> Optional nit: Feel free to move this early out to the previous line.

Done.

[Bernhard Bauer, 2015-06-22 21:16:17]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2015-06-22 21:16:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1194423002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2015-06-22 21:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194423002/40001

[nyquist, 2015-06-22 21:19:28]

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/1194423002/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/BuildInfo.java:130: public static
boolean isMncOrLater() {
On 2015/06/22 21:16:08, Bernhard Bauer wrote:
> On 2015/06/22 21:06:13, nyquist (OOO - back 6-29) wrote:
> > Optional nit: I thought it was supposed to be called Android M for now, not
> > 'MNC'?
> 
> TBH, I called it that just because "MncOrLater" looked more readable to me
than
> the single M in "MOrLater"... 0:-)

I must say I agree. It looked horrible. I just wasn't sure about the use of a
codename in public code. But then again, there's already the
Build.VERSION.CODENAME comparison below.

[commit-bot: I haz the power, 2015-06-22 23:47:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-22 23:48:19]

Patchset 3 (id:??) landed as
https://crrev.com/d74b322a46041b6838b3e0f36c0489bc9bca8554
Cr-Commit-Position: refs/heads/master@{#335585}