Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1194343003: Convert cast_unittests to run on Swarming. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@4_ash_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert cast_unittests to run on Swarming. Ran: ./manage.py --convert cast_unittests R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/524ea7dab551b07bd2a71cb29d4655651b93dd5c Cr-Commit-Position: refs/heads/master@{#335722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
M-A Ruel
I've sent the other CLs to Nico but I'd like to spread the load a ...
5 years, 6 months ago (2015-06-23 15:45:55 UTC) #1
Dirk Pranke
On 2015/06/23 15:45:55, M-A Ruel wrote: > I've sent the other CLs to Nico but ...
5 years, 6 months ago (2015-06-23 16:17:04 UTC) #2
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-23 16:17:35 UTC) #3
Nico
lgtm too
5 years, 6 months ago (2015-06-23 16:31:08 UTC) #5
M-A Ruel
On 2015/06/23 16:17:04, Dirk Pranke wrote: > Do you have a sense of how fast ...
5 years, 6 months ago (2015-06-23 17:17:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194343003/1
5 years, 6 months ago (2015-06-23 17:18:04 UTC) #8
Dirk Pranke
On 2015/06/23 17:17:07, M-A Ruel wrote: > On 2015/06/23 16:17:04, Dirk Pranke wrote: > > ...
5 years, 6 months ago (2015-06-23 17:31:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 19:05:48 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 19:06:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/524ea7dab551b07bd2a71cb29d4655651b93dd5c
Cr-Commit-Position: refs/heads/master@{#335722}

Powered by Google App Engine
This is Rietveld 408576698