Fix facebook_credentials_backend_unittest on android-content-shell.

Fix facebook_credentials_backend_unittest on android-content-shell.

NOTRY=true
BUG=170901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178609

[hartmanng, 2013-01-18 18:42:37]

Please take a look

[tonyg, 2013-01-18 18:44:39]

https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
File tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py
(right):

https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py:25:
options.browser_user_agent_type = 'desktop'
I think this should be in the real code instead of in the unittest code. Right?

[hartmanng, 2013-01-18 18:57:06]

https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
File tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py
(right):

https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py:25:
options.browser_user_agent_type = 'desktop'
On 2013/01/18 18:44:39, tonyg wrote:
> I think this should be in the real code instead of in the unittest code.
Right?

Hmm, good point, but I'm not entirely sure. Currently we set user agent through
the --user-agent= chrome flag, so it only gets set once per pageset at the very
start. Do we really want to force a desktop user agent for an entire pageset if
some of the pages require login?

As a side-note, we can also force a user-agent in a pageset file (top_25.json
currently uses desktop already).

[hartmanng, 2013-01-18 19:00:20]

On 2013/01/18 18:57:06, hartmanng wrote:
>
https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
> File tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py
> (right):
> 
>
https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
> tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py:25:
> options.browser_user_agent_type = 'desktop'
> On 2013/01/18 18:44:39, tonyg wrote:
> > I think this should be in the real code instead of in the unittest code.
> Right?
> 
> Hmm, good point, but I'm not entirely sure. Currently we set user agent
through
> the --user-agent= chrome flag, so it only gets set once per pageset at the
very
> start. Do we really want to force a desktop user agent for an entire pageset
if
> some of the pages require login?
> 
> As a side-note, we can also force a user-agent in a pageset file (top_25.json
> currently uses desktop already).

(also, if this patch works out https://codereview.chromium.org/11880034/ we
might be able to start setting user-agent on a page-by-page basis)

[tonyg, 2013-01-18 19:01:55]

On 2013/01/18 18:57:06, hartmanng wrote:
>
https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
> File tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py
> (right):
> 
>
https://codereview.chromium.org/11943014/diff/1/tools/telemetry/telemetry/for...
> tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py:25:
> options.browser_user_agent_type = 'desktop'
> On 2013/01/18 18:44:39, tonyg wrote:
> > I think this should be in the real code instead of in the unittest code.
> Right?
> 
> Hmm, good point, but I'm not entirely sure. Currently we set user agent
through
> the --user-agent= chrome flag, so it only gets set once per pageset at the
very
> start. Do we really want to force a desktop user agent for an entire pageset
if
> some of the pages require login?

Oh, I forgot about that. We don't want to force it for the entire pageset. Just
for the login page.

> 
> As a side-note, we can also force a user-agent in a pageset file (top_25.json
> currently uses desktop already).

[hartmanng, 2013-01-24 17:42:10]

https://codereview.chromium.org/11880034/ probably isn't going anywhere, which
means we won't have a good way (apart from restarting the browser) to set the
user agent on a page-by-page basis. So instead I fixed the
*_credentials_backend.py files so that login works on the mobile version of
facebook.

PTAL

[tonyg, 2013-01-24 18:06:33]

lgtm

[commit-bot: I haz the power, 2013-01-24 18:08:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11943014/17001

[commit-bot: I haz the power, 2013-01-24 18:10:39]

Change committed as 178609