Issue 11943008: The dev tools process does not actually need Web UI bindings.

Issue 11943008: The dev tools process does not actually need Web UI bindings. (Closed)

Created:
7 years, 11 months ago by Chris Evans

Modified:
7 years, 11 months ago

Reviewers:
Lei Zhang, jam, pfeldman

CC:
chromium-reviews, vsevik, pam+watch_chromium.org, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

The dev tools process does not actually need Web UI bindings. BUG=171065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177876

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/devtools/devtools_window.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/webui/devtools_ui.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

Seems to work on a full try run (the redness is flake AFAICT)

7 years, 11 months ago (2013-01-18 09:37:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/11943008/5003

7 years, 11 months ago (2013-01-19 23:31:10 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75920

7 years, 11 months ago (2013-01-20 01:54:00 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/11943008/5003

7 years, 11 months ago (2013-01-20 04:02:56 UTC) #7

commit-bot: I haz the power

7 years, 11 months ago (2013-01-20 06:30:51 UTC) #8

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Expand Messages | Collapse Messages