Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1194173004: Fix string HTML methods to call ToString (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix string HTML methods to call ToString Before this we were using + which calls valueOf which is not correct for these methods. BUG=v8:4222 LOG=N R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/6b268bce6a835b0517468b4b4253b7ce2affdad8 Cr-Commit-Position: refs/heads/master@{#29202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M src/string.js View 1 chunk +16 lines, -13 lines 0 comments Download
M test/mjsunit/es6/string-html.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-22 17:56:17 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-22 18:00:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194173004/1
5 years, 6 months ago (2015-06-22 18:17:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 19:07:14 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:07:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b268bce6a835b0517468b4b4253b7ce2affdad8
Cr-Commit-Position: refs/heads/master@{#29202}

Powered by Google App Engine
This is Rietveld 408576698