[webcrypto] Add key generation for AES-GCM and AES-KW for NSS.

[webcrypto] Add key generation for AES-GCM and AES-KW for NSS.

BUG=245025
TEST=content_unittests --gtest_filter="WebCryptoImpl*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242255

[eroman, 2013-12-20 01:28:16]

lgtm

https://codereview.chromium.org/119413002/diff/1/content/renderer/webcrypto/w...
File content/renderer/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/119413002/diff/1/content/renderer/webcrypto/w...
content/renderer/webcrypto/webcrypto_util.cc:175: blink::WebCryptoAlgorithm
CreateAesKwKeyGenAlgorithm(
I don't think this should go in the webcrypto_util.h.

I see webcrypto_util.h as functions which are used by non-test code (for
instance NSS implementation and OpenSSL implementation, or test code + non-test
code).

If something is purely for test it should just go in the _unittest.cc file.

Otherwise we are relying on the linker to strip dead code (it probably will, but
good hygiene not to include unnecessary functions in the release build of
browser).

[padolph, 2013-12-20 02:03:00]

https://codereview.chromium.org/119413002/diff/1/content/renderer/webcrypto/w...
File content/renderer/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/119413002/diff/1/content/renderer/webcrypto/w...
content/renderer/webcrypto/webcrypto_util.cc:175: blink::WebCryptoAlgorithm
CreateAesKwKeyGenAlgorithm(
On 2013/12/20 01:28:16, eroman wrote:
> I don't think this should go in the webcrypto_util.h.
> 
> I see webcrypto_util.h as functions which are used by non-test code (for
> instance NSS implementation and OpenSSL implementation, or test code +
non-test
> code).
> 
> If something is purely for test it should just go in the _unittest.cc file.
> 
> Otherwise we are relying on the linker to strip dead code (it probably will,
but
> good hygiene not to include unnecessary functions in the release build of
> browser).

Done.

[commit-bot: I haz the power, 2013-12-20 02:05:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/119413002/20001

[commit-bot: I haz the power, 2013-12-20 10:24:53]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 18:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/119413002/20001

[commit-bot: I haz the power, 2013-12-20 20:01:52]

Failed to apply patch for content/renderer/webcrypto/webcrypto_util.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/webcrypto/webcrypto_util.cc
  Hunk #2 FAILED at 153.
  1 out of 2 hunks FAILED -- saving rejects to file
content/renderer/webcrypto/webcrypto_util.cc.rej

Patch:       content/renderer/webcrypto/webcrypto_util.cc
Index: content/renderer/webcrypto/webcrypto_util.cc
diff --git a/content/renderer/webcrypto/webcrypto_util.cc
b/content/renderer/webcrypto/webcrypto_util.cc
index
977c282c63b72230c52704bb74a9691d04ee0eec..ae8ade48903e2b045aa207813f80fa4fc85d9fc1
100644
--- a/content/renderer/webcrypto/webcrypto_util.cc
+++ b/content/renderer/webcrypto/webcrypto_util.cc
@@ -15,13 +15,6 @@ namespace webcrypto {
 
 namespace {
 
-blink::WebCryptoAlgorithm CreateAesKeyGenAlgorithm(
-    blink::WebCryptoAlgorithmId aes_alg_id,
-    unsigned short length) {
-  return blink::WebCryptoAlgorithm::adoptParamsAndCreate(
-      aes_alg_id, new blink::WebCryptoAesKeyGenParams(length));
-}
-
 bool IsHashAlgorithm(blink::WebCryptoAlgorithmId alg_id) {
   return alg_id == blink::WebCryptoAlgorithmIdSha1 ||
          alg_id == blink::WebCryptoAlgorithmIdSha224 ||
@@ -160,18 +153,6 @@ blink::WebCryptoAlgorithm CreateAesGcmAlgorithm(
                                        tag_length_bytes));
 }
 
-blink::WebCryptoAlgorithm CreateAesCbcKeyGenAlgorithm(
-    unsigned short key_length_bits) {
-  return CreateAesKeyGenAlgorithm(blink::WebCryptoAlgorithmIdAesCbc,
-                                  key_length_bits);
-}
-
-blink::WebCryptoAlgorithm CreateAesGcmKeyGenAlgorithm(
-    unsigned short key_length_bits) {
-  return CreateAesKeyGenAlgorithm(blink::WebCryptoAlgorithmIdAesGcm,
-                                  key_length_bits);
-}
-
 }  // namespace webcrypto
 
 }  // namespace content

[commit-bot: I haz the power, 2013-12-20 20:46:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/119413002/70001

[commit-bot: I haz the power, 2013-12-20 22:56:03]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-21 01:49:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/119413002/70001

[commit-bot: I haz the power, 2013-12-21 04:30:18]

Change committed as 242255