EditableText underlines the word being edited

sky/sdk/lib/editing/editable_text.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:async';
 
+import '../painting/text_style.dart';
 import '../widgets/basic.dart';
 import 'editable_string.dart';
 
 class EditableText extends Component {
 
   EditableText({String key, this.value, this.focused})
       : super(key: key, stateful: true);
 
   // static final Style _cursorStyle = new Style('''
   //   width: 2px;
   //   height: 1.2em;
   //   vertical-align: top;
   //   background-color: ${Blue[500]};'''
   // );
 
-  // static final Style _composingStyle = new Style('''
-  //   text-decoration: underline;'''
-  // );
+  static const TextStyle _plainStyle = const TextStyle();

[Hixie, 2015/06/19 22:39:44]

Can't this be null?

[hansmuller, 2015/06/19 23:32:11]

Not at the moment (StyledText doesn't support that). Eventually I think this
TextStyle will come from the theme.

+  static const TextStyle _composingStyle = const TextStyle(decoration: underline);

[abarth-chromium, 2015/06/19 22:41:38]

I would just inline these in the one place they're each used.  The |const| will
mean we only actually allocate them at compile time.

[hansmuller, 2015/06/19 23:32:11]

Done.

 
   EditableString value;
   bool focused;
 
   void syncFields(EditableText source) {
     value = source.value;
     focused = source.focused;
   }
 
   Timer _cursorTimer;
@@ skipping 22 matching lines @@
     _cursorTimer = null;
     _showCursor = false;
   }
 
   Widget build() {
     if (focused && _cursorTimer == null)
       _startCursorTimer();
     else if (!focused && _cursorTimer != null)
       _stopCursorTimer();
 
-    //List<Widget> children = new List<Widget>();
-    String hack = "";
-
     if (!value.composing.isValid) {
-      // children.add(new TextFragment(value.text));
-      hack += value.text;
-    } else {
-      hack += value.textBefore(value.composing);
-      hack += value.textInside(value.composing);
-      hack += value.textAfter(value.composing);
-      // if (!composing.isEmpty) {
-      //   children.add(new TextFragment(
-      //     composing,
-      //     key: 'composing',
-      //     style: _composingStyle
-      //   ));
-      // }
-
-      // String afterComposing = value.textAfter(value.composing);
-      // if (!afterComposing.isEmpty)
-      //   children.add(new TextFragment(afterComposing));
+      return new Text(value.text);
     }
 
-    // if (_showCursor)
-    //   children.add(new Container(
-    //     key: 'cursor',
-    //     // style: _cursorStyle
-    //     ));
-
-    return new Text(hack);
+    return new StyledText(elements: [
+      _plainStyle,
+      value.textBefore(value.composing),
+      [_composingStyle, value.textInside(value.composing)],
+      value.textAfter(value.composing)
+    ]);
   }
 }